Opened 9 years ago
Closed 9 years ago
#16145 closed enhancement (fixed)
FiniteStateMachine.asymptotic_moments: New method
Reported by: | cheuberg | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.3 |
Component: | combinatorics | Keywords: | finite_state_machine |
Cc: | skropf | Merged in: | |
Authors: | Clemens Heuberger, Sara Kropf | Reviewers: | Daniel Krenn |
Report Upstream: | N/A | Work issues: | |
Branch: | b2aff73 (Commits, GitHub, GitLab) | Commit: | b2aff73c6918764ae5d7a8a99699b9d8bd9b34fa |
Dependencies: | #16132, #16138, #16140, #16141, #16142, #16143, #16144 | Stopgaps: |
Description
Returns the main terms of expectation and variance of the sum of output labels and its covariance with the sum of input labels. This implements one of the results of the forthcoming paper: Clemens Heuberger, Sara Kropf and Stephan Wagner, Combinatorial Characterization of Independent Transducers via Functional Digraphs.
Change History (21)
comment:1 Changed 9 years ago by
Status: | new → needs_review |
---|
comment:2 Changed 9 years ago by
Branch: | u/cheuberg/asymptotic-moments → u/cheuberg/ticket/16145 |
---|---|
Created: | Apr 12, 2014, 5:20:10 AM → Apr 12, 2014, 5:20:10 AM |
Modified: | Apr 12, 2014, 5:20:22 AM → Apr 12, 2014, 5:20:22 AM |
comment:3 Changed 9 years ago by
Commit: | 3c115fc222792ac1b346ca86ad8defe0fcb075c4 → 0a8378a7d51eba3fe9184d151d4c6b077020f583 |
---|
comment:4 Changed 9 years ago by
Dependencies: | #16138, #16140, #16142, #16143, #16144 → #16132, #16138, #16140, #16141, #16142, #16143, #16144 |
---|
comment:5 Changed 9 years ago by
Branch: | u/cheuberg/ticket/16145 → u/cheuberg/fsm/asymptotic-moments |
---|
comment:6 Changed 9 years ago by
Commit: | 0a8378a7d51eba3fe9184d151d4c6b077020f583 → 8e04e12b97f8938cc3eb9fe936cbc9813f488807 |
---|
- merged current versions of all dependencies so that this merges cleanly with 6.2.beta8
- removed reference HKW2014 from
FiniteStateMachine.final_components
in order to avoid an error due to a duplicate reference - replaced one new instance of "raise E, V" by "raise E(V)"
comment:7 Changed 9 years ago by
Branch: | u/cheuberg/fsm/asymptotic-moments → u/dkrenn/fsm/asymptotic-moments |
---|
comment:8 Changed 9 years ago by
Commit: | 8e04e12b97f8938cc3eb9fe936cbc9813f488807 → d22eea2bca3c05fecad3fc34900f637f58b16f12 |
---|
Made a couple of minor changes during the review.
New commits:
d22eea2 | a couple of minor changes during review
|
comment:9 Changed 9 years ago by
Branch: | u/dkrenn/fsm/asymptotic-moments → u/cheuberg/fsm/asymptotic-moments |
---|---|
Commit: | d22eea2bca3c05fecad3fc34900f637f58b16f12 → 1908a5daf8c36f02bef0f801b5df6d9ce134c7bd |
Summary: | FiniteStateMachine.output_sum_asymptotics: New method → FiniteStateMachine.asymptotic_moments: New method |
reviewed your changes, those are fine for me.
Pushed a few commits:
- 89ebf74 added two links in docstring
- 40ecd46 added explanation to third example
- 1447cd5 add examples to examples
- f13725d add explanation on PolynomialRing? vs SymbolicRing?
- 878acff replaced parameter verbose by sage.misc.misc.verbose
- 40da528 Explanations for >1 final components, periodic final components
- 00e063e upgraded two tests to examples
- 1908a5d unique initial states, all states are final
Finally, changed summary to reflect a name change in the method which occurred some time ago.
Please review those changes.
Last 10 new commits:
8e04e12 | replaced one new instance of raise E, V by raise E(V) (cf. #15990)
|
d22eea2 | a couple of minor changes during review
|
89ebf74 | FiniteStateMachine.asymptotic_moments: added two links in docstring
|
40ecd46 | FiniteStateMachine.asymptotic_moments: added explanation to third example
|
1447cd5 | FiniteStateMachine.asymptotic_moments: add examples to examples
|
f13725d | asymptotic_moments: add explanation on PolynomialRing vs SymbolicRing
|
878acff | asymptotic_moments: replaced parameter verbose by sage.misc.misc.verbose
|
40da528 | Explanations for >1 final components, periodic final components
|
00e063e | asymptotic_moments: upgraded two tests to examples
|
1908a5d | asymptotic_moments: unique initial states, all states are final
|
comment:10 Changed 9 years ago by
Commit: | 1908a5daf8c36f02bef0f801b5df6d9ce134c7bd → 78997f5ca57eb50cb66fa250f3861b46b0e17360 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
78997f5 | Corrected and improved version of commit 40da528
|
comment:11 Changed 9 years ago by
Commit: | 78997f5ca57eb50cb66fa250f3861b46b0e17360 → d56a769c654daf5874acb00f6ff5cd265ceb9ddc |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
d56a769 | Rewrote asymptotic_moments to output en+Order(1) etc.
|
comment:12 follow-up: 18 Changed 9 years ago by
I expect a rather trivial merge conflict with #16207 --- so whichever of the two tickets is reviewed earlier should be merged into the other.
comment:13 Changed 9 years ago by
Commit: | d56a769c654daf5874acb00f6ff5cd265ceb9ddc → 0b1200de72dfcce1356c5d179a4a10bbe901f8cc |
---|
comment:14 Changed 9 years ago by
trac's automerge fails. Patch based on 6.2.beta8, all dependencies but #16143 are in 6.2.rc0, merges cleanly with 6.2.rc0.
comment:15 Changed 9 years ago by
Cc: | dkrenn removed |
---|---|
Reviewers: | → Daniel Krenn |
Everything looks fine for me.
comment:16 Changed 9 years ago by
Branch: | u/cheuberg/fsm/asymptotic-moments → u/dkrenn/fsm/asymptotic-moments |
---|
comment:17 Changed 9 years ago by
Commit: | 0b1200de72dfcce1356c5d179a4a10bbe901f8cc → b2aff73c6918764ae5d7a8a99699b9d8bd9b34fa |
---|
During review: very minor changes in docstring.
New commits:
b2aff73 | very minor doctest changes: some spacings; added an 'a'
|
comment:18 Changed 9 years ago by
Replying to cheuberg:
I expect a rather trivial merge conflict with #16207 --- so whichever of the two tickets is reviewed earlier should be merged into the other.
#16207 now depends on this ticket, so merge conflict is taken care of.
Replying to dkrenn:
During review: very minor changes in docstring.
New commits:
b2aff73 very minor doctest changes: some spacings; added an 'a'
fine with me.
comment:19 Changed 9 years ago by
Status: | needs_review → positive_review |
---|
Ok, let's set this to positive...
comment:20 Changed 9 years ago by
Milestone: | sage-6.2 → sage-6.3 |
---|
comment:21 Changed 9 years ago by
Branch: | u/dkrenn/fsm/asymptotic-moments → b2aff73c6918764ae5d7a8a99699b9d8bd9b34fa |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Updated reference HKW2014 to point to arxiv:1404.3680.