Opened 8 years ago

Closed 8 years ago

#16145 closed enhancement (fixed)

FiniteStateMachine.asymptotic_moments: New method

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-6.3
Component: combinatorics Keywords: finite_state_machine
Cc: skropf Merged in:
Authors: Clemens Heuberger, Sara Kropf Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: b2aff73 (Commits, GitHub, GitLab) Commit: b2aff73c6918764ae5d7a8a99699b9d8bd9b34fa
Dependencies: #16132, #16138, #16140, #16141, #16142, #16143, #16144 Stopgaps:

Status badges

Description

Returns the main terms of expectation and variance of the sum of output labels and its covariance with the sum of input labels. This implements one of the results of the forthcoming paper: Clemens Heuberger, Sara Kropf and Stephan Wagner, Combinatorial Characterization of Independent Transducers via Functional Digraphs.

Change History (21)

comment:1 Changed 8 years ago by cheuberg

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by cheuberg

  • Branch changed from u/cheuberg/asymptotic-moments to u/cheuberg/ticket/16145
  • Created changed from 04/12/14 05:20:10 to 04/12/14 05:20:10
  • Modified changed from 04/12/14 05:20:22 to 04/12/14 05:20:22

comment:3 Changed 8 years ago by cheuberg

  • Commit changed from 3c115fc222792ac1b346ca86ad8defe0fcb075c4 to 0a8378a7d51eba3fe9184d151d4c6b077020f583

Updated reference HKW2014 to point to arxiv:1404.3680.

comment:4 Changed 8 years ago by cheuberg

  • Dependencies changed from #16138, #16140, #16142, #16143, #16144 to #16132, #16138, #16140, #16141, #16142, #16143, #16144

comment:5 Changed 8 years ago by cheuberg

  • Branch changed from u/cheuberg/ticket/16145 to u/cheuberg/fsm/asymptotic-moments

comment:6 Changed 8 years ago by cheuberg

  • Commit changed from 0a8378a7d51eba3fe9184d151d4c6b077020f583 to 8e04e12b97f8938cc3eb9fe936cbc9813f488807
  • merged current versions of all dependencies so that this merges cleanly with 6.2.beta8
  • removed reference HKW2014 from FiniteStateMachine.final_components in order to avoid an error due to a duplicate reference
  • replaced one new instance of "raise E, V" by "raise E(V)"

comment:7 Changed 8 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/asymptotic-moments to u/dkrenn/fsm/asymptotic-moments

comment:8 Changed 8 years ago by dkrenn

  • Commit changed from 8e04e12b97f8938cc3eb9fe936cbc9813f488807 to d22eea2bca3c05fecad3fc34900f637f58b16f12

Made a couple of minor changes during the review.

New commits:

​d22eea2a couple of minor changes during review

comment:9 Changed 8 years ago by cheuberg

  • Branch changed from u/dkrenn/fsm/asymptotic-moments to u/cheuberg/fsm/asymptotic-moments
  • Commit changed from d22eea2bca3c05fecad3fc34900f637f58b16f12 to 1908a5daf8c36f02bef0f801b5df6d9ce134c7bd
  • Summary changed from FiniteStateMachine.output_sum_asymptotics: New method to FiniteStateMachine.asymptotic_moments: New method

reviewed your changes, those are fine for me.

Pushed a few commits:

Finally, changed summary to reflect a name change in the method which occurred some time ago.

Please review those changes.

Last 10 new commits:

​8e04e12replaced one new instance of raise E, V by raise E(V) (cf. #15990)
​d22eea2a couple of minor changes during review
​89ebf74FiniteStateMachine.asymptotic_moments: added two links in docstring
​40ecd46FiniteStateMachine.asymptotic_moments: added explanation to third example
​1447cd5FiniteStateMachine.asymptotic_moments: add examples to examples
​f13725dasymptotic_moments: add explanation on PolynomialRing vs SymbolicRing
​878acffasymptotic_moments: replaced parameter verbose by sage.misc.misc.verbose
​40da528Explanations for >1 final components, periodic final components
​00e063easymptotic_moments: upgraded two tests to examples
​1908a5dasymptotic_moments: unique initial states, all states are final

comment:10 Changed 8 years ago by git

  • Commit changed from 1908a5daf8c36f02bef0f801b5df6d9ce134c7bd to 78997f5ca57eb50cb66fa250f3861b46b0e17360

Branch pushed to git repo; I updated commit sha1. New commits:

​78997f5Corrected and improved version of commit 40da528

comment:11 Changed 8 years ago by git

  • Commit changed from 78997f5ca57eb50cb66fa250f3861b46b0e17360 to d56a769c654daf5874acb00f6ff5cd265ceb9ddc

Branch pushed to git repo; I updated commit sha1. New commits:

​d56a769Rewrote asymptotic_moments to output en+Order(1) etc.

comment:12 follow-up: Changed 8 years ago by cheuberg

I expect a rather trivial merge conflict with #16207 --- so whichever of the two tickets is reviewed earlier should be merged into the other.

comment:13 Changed 8 years ago by git

  • Commit changed from d56a769c654daf5874acb00f6ff5cd265ceb9ddc to 0b1200de72dfcce1356c5d179a4a10bbe901f8cc

Branch pushed to git repo; I updated commit sha1. New commits:

​24b6d69explained the shifting in the Gray code-construction differently
​0b1200dMerge branch 't/16143/fsm/example_gray_code' into fsm/asymptotic-moments

comment:14 Changed 8 years ago by cheuberg

trac's automerge fails. Patch based on 6.2.beta8, all dependencies but #16143 are in 6.2.rc0, merges cleanly with 6.2.rc0.

comment:15 Changed 8 years ago by dkrenn

  • Cc dkrenn removed
  • Reviewers set to Daniel Krenn

Everything looks fine for me.

comment:16 Changed 8 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/asymptotic-moments to u/dkrenn/fsm/asymptotic-moments

comment:17 Changed 8 years ago by dkrenn

  • Commit changed from 0b1200de72dfcce1356c5d179a4a10bbe901f8cc to b2aff73c6918764ae5d7a8a99699b9d8bd9b34fa

During review: very minor changes in docstring.

New commits:

​b2aff73very minor doctest changes: some spacings; added an 'a'

comment:18 in reply to: ↑ 12 Changed 8 years ago by cheuberg

Replying to cheuberg:

I expect a rather trivial merge conflict with #16207 --- so whichever of the two tickets is reviewed earlier should be merged into the other.

#16207 now depends on this ticket, so merge conflict is taken care of.

Replying to dkrenn:

During review: very minor changes in docstring.

New commits:

​b2aff73very minor doctest changes: some spacings; added an 'a'

fine with me.

comment:19 Changed 8 years ago by dkrenn

  • Status changed from needs_review to positive_review

Ok, let's set this to positive...

comment:20 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:21 Changed 8 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/asymptotic-moments to b2aff73c6918764ae5d7a8a99699b9d8bd9b34fa
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.