Opened 6 years ago

Closed 5 years ago

#16144 closed enhancement (fixed)

Transducer.cartesian_product: additional example (11 blocks minus 10 blocks)

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.2
Component: combinatorics Keywords: finite_state_machine
Cc: dkrenn, skropf Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: eaa83be (Commits) Commit: eaa83be472137e6b75d77d209a0213f342250979
Dependencies: #16132, #16141, #16142 Stopgaps:

Description

In order to illustrate the use of the version of Transducer.cartesian_product introduced in #16016 combined with the common transducers introduced in #16142, I added an additional example to the docstring of Transducer.cartesian_product. It computes the number of 11 blocks minus the number of 10 blocks over the alphabet [0, 1].

Change History (9)

comment:1 Changed 6 years ago by cheuberg

  • Status changed from new to needs_review

comment:2 Changed 6 years ago by cheuberg

  • Branch changed from u/cheuberg/fsm/cartesian-product-intersection to u/cheuberg/fsm/cartesian-product-intersection-additional-example
  • Commit changed from 7633cacfb8a13dc5fc808a947e7f4db3e1bd9ef8 to d5d2ba54fb973985e4031e102d92388f0570240c

comment:3 Changed 6 years ago by git

  • Commit changed from d5d2ba54fb973985e4031e102d92388f0570240c to 285944a0f38f2d57b3b8ba984035229b0fa58a81

Branch pushed to git repo; I updated commit sha1. New commits:

​ed93dd3Minor changes during review.
​3820c49corrected whitespaceerror
​a14dd81Merge remote-tracking branch 'origin/u/dkrenn/ticket/16132' into fsm/process_output_new-on-beta8
​86f8452improved various docstrings in finite_state_machine_generators.py
​4a36b1aMerge remote-tracking branch 'origin/u/dkrenn/fsm/count_subblock_occurrences' into fsm/count_subblock_occurrences-on-beta8
​f344fd8reviewer patch: improved function operator; extended and rewrote docstrings
​138132fMerge remote-tracking branch 'origin/u/dkrenn/fsm/operator_transducers' into fsm/example_gray_code-on-beta8
​285944aMerge branch 't/16142/fsm/operator_transducers-on-beta8' into fsm/cartesian-product-intersection-additional-example

comment:4 Changed 6 years ago by cheuberg

Merged current version of dependency #16142

comment:5 Changed 6 years ago by cheuberg

  • Dependencies changed from #16142 to #16132, #16141, #16142

comment:6 Changed 6 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/cartesian-product-intersection-additional-example to u/dkrenn/fsm/cartesian-product-intersection-additional-example

comment:7 follow-up: Changed 6 years ago by dkrenn

  • Commit changed from 285944a0f38f2d57b3b8ba984035229b0fa58a81 to eaa83be472137e6b75d77d209a0213f342250979
  • Reviewers set to Daniel Krenn

Looks fine. I've made very minor changes. Please review them, if good, then set to positive_review.

Last 10 new commits:

​d5d2ba5Checked transducer with concrete input
​ed93dd3Minor changes during review.
​3820c49corrected whitespaceerror
​a14dd81Merge remote-tracking branch 'origin/u/dkrenn/ticket/16132' into fsm/process_output_new-on-beta8
​86f8452improved various docstrings in finite_state_machine_generators.py
​4a36b1aMerge remote-tracking branch 'origin/u/dkrenn/fsm/count_subblock_occurrences' into fsm/count_subblock_occurrences-on-beta8
​f344fd8reviewer patch: improved function operator; extended and rewrote docstrings
​138132fMerge remote-tracking branch 'origin/u/dkrenn/fsm/operator_transducers' into fsm/example_gray_code-on-beta8
​285944aMerge branch 't/16142/fsm/operator_transducers-on-beta8' into fsm/cartesian-product-intersection-additional-example
​eaa83beadded "input_alphabet=" in one doctest for clearification; one PEP8-spaceing

comment:8 in reply to: ↑ 7 Changed 6 years ago by cheuberg

  • Status changed from needs_review to positive_review

Replying to dkrenn:

Looks fine. I've made very minor changes. Please review them, if good, then set to positive_review.

Cross-reviewed these very minor changes. Setting status to positive_review as per your instruction.

comment:9 Changed 5 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/cartesian-product-intersection-additional-example to eaa83be472137e6b75d77d209a0213f342250979
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.