Opened 6 years ago

Closed 5 years ago

#16141 closed enhancement (fixed)

TransducerGenerators: New class, collecting common transducers

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.2
Component: combinatorics Keywords: finite_state_machine
Cc: skropf Merged in:
Authors: Clemens Heuberger, Daniel Krenn, Sara Kropf Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 4a36b1a (Commits) Commit: 4a36b1af5a9ec87a2fc9eae8c92aef21414cd80b
Dependencies: #15849, #16132 Stopgaps:

Description

Inspired by the (Di)graph_generators, provide a class TransducerGenerators where commonly usable transducers performing simple tasks can be collected. As for graphs, an abbreviation transducers is injected in the global namespace by a lazy_import. To start with, there is a Identity transducer and a CountSubblockOccurrences transducer.

Change History (7)

comment:1 Changed 6 years ago by cheuberg

  • Status changed from new to needs_review

comment:2 follow-up: Changed 6 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/count_subblock_occurrences to u/dkrenn/fsm/count_subblock_occurrences
  • Cc dkrenn skropf removed
  • Commit changed from 5d6576790363a5420da97d892020de617054dd71 to 86f84524b8ec4ef260c4ee5059ad2547244621b7
  • Reviewers set to Daniel Krenn

During the review, I rewrote parts of the docstring of the new generator file (inserted some text at the top; some minor changes). Please review those changes.

For me this is a positive review (all tests pass, docs looking fine, coverage 100%), so if someones agrees with my changes, change the status of this ticket.


Last 10 new commits:

75aa9e1corrected doctests (after change of output)
d18312eMerge branch 'fsm/state_color' into fsm/process_output_new
2d43fddFiniteStateMachine: add failing doctests: non-hashable colors
547968aFiniteStateMachine.product_FiniteStateMachine, composition: fix unhashable colors
d51be51Automaton.determinisation(): docstring on hashable colors
c5dd860Merge branch 'fsm/state_color' into fsm/process_output_new
70294bftrac ticket number added
4a53b09Merge branch '#16132' into fsm/count_subblock_occurrences
5d65767Edit doctests due to #16132 change.
86f8452improved various docstrings in finite_state_machine_generators.py

comment:3 Changed 6 years ago by dkrenn

  • Authors changed from Clemens Heuberger, Sara Kropf to Clemens Heuberger, Daniel Krenn, Sara Kropf

comment:4 in reply to: ↑ 2 Changed 6 years ago by cheuberg

Replying to dkrenn:

During the review, I rewrote parts of the docstring of the new generator file (inserted some text at the top; some minor changes). Please review those changes.

For me this is a positive review (all tests pass, docs looking fine, coverage 100%), so if someones agrees with my changes, change the status of this ticket.

I reviewed your changes and agree with them.

comment:5 Changed 6 years ago by dkrenn

  • Cc skropf added

comment:6 Changed 6 years ago by dkrenn

  • Branch changed from u/dkrenn/fsm/count_subblock_occurrences to u/dkrenn/fsm/count_subblock_occurrences-on-beta8
  • Commit changed from 86f84524b8ec4ef260c4ee5059ad2547244621b7 to 4a36b1af5a9ec87a2fc9eae8c92aef21414cd80b
  • Status changed from needs_review to positive_review

This merges on 6.2.beta8 + #16132


Last 10 new commits:

70294bftrac ticket number added
ed93dd3Minor changes during review.
3820c49corrected whitespaceerror
a14dd81Merge remote-tracking branch 'origin/u/dkrenn/ticket/16132' into fsm/process_output_new-on-beta8
be59e47TransducerGenerators: New class, collecting common transducers
7a907acminor corrections
4a53b09Merge branch '#16132' into fsm/count_subblock_occurrences
5d65767Edit doctests due to #16132 change.
86f8452improved various docstrings in finite_state_machine_generators.py
4a36b1aMerge remote-tracking branch 'origin/u/dkrenn/fsm/count_subblock_occurrences' into fsm/count_subblock_occurrences-on-beta8

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/count_subblock_occurrences-on-beta8 to 4a36b1af5a9ec87a2fc9eae8c92aef21414cd80b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.