Opened 8 years ago
Closed 8 years ago
#16139 closed enhancement (fixed)
FiniteStateMachine.induced_sub_finite_state_machine: new method
Reported by: | cheuberg | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.2 |
Component: | combinatorics | Keywords: | finite_state_machine |
Cc: | Merged in: | ||
Authors: | Clemens Heuberger, Sara Kropf | Reviewers: | Daniel Krenn |
Report Upstream: | N/A | Work issues: | |
Branch: | 99eb1c0 (Commits, GitHub, GitLab) | Commit: | 99eb1c0ee82fece7141e921fbff550e5a5e607f4 |
Dependencies: | Stopgaps: |
Description
New method to construct a sub-finite-state-machine of the finite state machine induced by some given states.
Change History (6)
comment:1 Changed 8 years ago by
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Branch changed from u/cheuberg/fsm/induced_subgraph to u/dkrenn/fsm/induced_subgraph
- Cc dkrenn skropf removed
- Commit changed from ea09f995eb84fffc02d948f3baa1ee49bdf133bb to 5a0f805dd4aab84b2bb4e71ede8cce62d6364a9b
- Reviewers set to Daniel Krenn
- Status changed from needs_review to positive_review
comment:3 Changed 8 years ago by
- Commit changed from 5a0f805dd4aab84b2bb4e71ede8cce62d6364a9b to 99eb1c0ee82fece7141e921fbff550e5a5e607f4
- Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
99eb1c0 | in docstring: added "an"
|
comment:4 Changed 8 years ago by
New commits:
3fcf289 | FiniteStateMachine.induced_sub_finite_state_machine: new method
|
f6cfad4 | fixed error message in induced_sub_finite_state_machine
|
ea09f99 | FiniteStateMachine.induced_sub_finite_state_machine: Removed obsolete remark from docstring
|
5a0f805 | minor changes in docstring of .induced_sub_finite_state_machine
|
99eb1c0 | in docstring: added "an"
|
comment:5 Changed 8 years ago by
- Status changed from needs_review to positive_review
comment:6 Changed 8 years ago by
- Branch changed from u/dkrenn/fsm/induced_subgraph to 99eb1c0ee82fece7141e921fbff550e5a5e607f4
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I've made very small changes in the docstring. The patch does what it should do, doctests pass, documentation looks fine. Therefore, positive review.
New commits:
FiniteStateMachine.induced_sub_finite_state_machine: new method
fixed error message in induced_sub_finite_state_machine
FiniteStateMachine.induced_sub_finite_state_machine: Removed obsolete remark from docstring
minor changes in docstring of .induced_sub_finite_state_machine