Opened 8 years ago
Closed 8 years ago
#16138 closed enhancement (fixed)
FiniteStateMachine.is_complete: new method
Reported by: | cheuberg | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.2 |
Component: | combinatorics | Keywords: | finite_state_machine |
Cc: | Merged in: | ||
Authors: | Clemens Heuberger, Sara Kropf | Reviewers: | Daniel Krenn |
Report Upstream: | N/A | Work issues: | |
Branch: | 368dc51 (Commits, GitHub, GitLab) | Commit: | 368dc515801137ecfebb0c57fd94a92248d8409b |
Dependencies: | Stopgaps: |
Description
Implemented a method checking whether a Finite State Machine is complete.
A finite state machine is said to be complete if for each state q and each letter a of the input alphabet, there is exactly one transition leaving q with input label a.
Change History (7)
comment:1 Changed 8 years ago by
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Branch changed from u/cheuberg/fsm/is_complete to u/dkrenn/fsm/is_complete
- Cc skropf dkrenn removed
- Commit changed from d393006ce6e143aadd49696ae763b6b4c784513d to 0913692f72cbd29c8ad13dedb761a6f547f70e08
- Reviewers set to Daniel Krenn
comment:3 Changed 8 years ago by
- Branch changed from u/dkrenn/fsm/is_complete to u/cheuberg/ticket/16138
- Created changed from 04/12/14 02:52:33 to 04/12/14 02:52:33
- Modified changed from 04/15/14 13:53:01 to 04/15/14 13:53:01
comment:4 Changed 8 years ago by
- Commit changed from 0913692f72cbd29c8ad13dedb761a6f547f70e08 to 677088e27b4bfb29ed15a38ede145ebf4f06fa56
Three of the minor changes in commit 0913692f72cbd29c8ad13dedb761a6f547f70e08 concerned code copied from is_deterministic to is_complete. Thus, backported those minor changes to is_deterministic
comment:5 Changed 8 years ago by
- Branch changed from u/cheuberg/ticket/16138 to u/cheuberg/fsm/is_complete
- Commit changed from 677088e27b4bfb29ed15a38ede145ebf4f06fa56 to 368dc515801137ecfebb0c57fd94a92248d8409b
Pushed one further commit changing one instance of raise E, V
to raise E(V)
, cf. #15990
comment:6 Changed 8 years ago by
- Status changed from needs_review to positive_review
reviewed again. Everything is fine.
comment:7 Changed 8 years ago by
- Branch changed from u/cheuberg/fsm/is_complete to 368dc515801137ecfebb0c57fd94a92248d8409b
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I've reviewed it (and made some minor changes). Doctests pass, documentation looks ok. For me this is a positive review, after someone checked the minor changes I've made.
New commits:
FiniteStateMachine.is_complete: new method.
corrected docstring of is_complete
minor changes during review