Opened 9 years ago
Closed 9 years ago
#16132 closed enhancement (fixed)
adapting output of FiniteStateMachine.process and __call__ to Automaton and Transducer
Reported by: | dkrenn | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.2 |
Component: | combinatorics | Keywords: | finite state machine, process, output |
Cc: | cheuberg, skropf | Merged in: | |
Authors: | Daniel Krenn | Reviewers: | Clemens Heuberger |
Report Upstream: | N/A | Work issues: | |
Branch: | afc15e5 (Commits, GitHub, GitLab) | Commit: | afc15e590d313a04c2a2aedb67203994865908ee |
Dependencies: | #16128, #16061, #15990 | Stopgaps: |
Description (last modified by )
Currently, there is only .process
and .__call__
in the abstract base class FiniteStateMachine
. The outputs do not depend on the actual type (automaton/transducer). The aim of this ticket is to change this and produce an appropriate output for each type of finite state machine. When using .__call__
in an automaton this is whether an input was accepted (and not more); a transducer gives the only the produces output.
(Since there is a change in the output, we give a deprecation warning.)
Change History (16)
comment:1 Changed 9 years ago by
Authors: | → Daniel Krenn |
---|---|
Branch: | → u/dkrenn/fsm/process_output_new |
Commit: | → 70294bf300ddc75671aba8f517fd464aacaecbb4 |
Status: | new → needs_review |
comment:2 Changed 9 years ago by
Dependencies: | → #15963, #16061 |
---|
comment:3 Changed 9 years ago by
Description: | modified (diff) |
---|
comment:4 Changed 9 years ago by
Branch: | u/dkrenn/fsm/process_output_new → u/cheuberg/ticket/16132 |
---|---|
Created: | Apr 11, 2014, 1:37:17 PM → Apr 11, 2014, 1:37:17 PM |
Modified: | Apr 12, 2014, 4:06:28 AM → Apr 12, 2014, 4:06:28 AM |
comment:5 Changed 9 years ago by
Commit: | 70294bf300ddc75671aba8f517fd464aacaecbb4 → ed93dd3be386540d686ffea0c831ebd71f7ea871 |
---|---|
Dependencies: | #15963, #16061 → #16128, #16061 |
comment:6 Changed 9 years ago by
Reviewers: | → Clemens Heuberger |
---|
comment:7 Changed 9 years ago by
Branch: | u/cheuberg/ticket/16132 → u/dkrenn/ticket/16132 |
---|---|
Commit: | ed93dd3be386540d686ffea0c831ebd71f7ea871 → 3820c49851711ebffb12e230b27e9faad2d79b6d |
Cross-reviewed your changes; corrected one whitespaceerror. Feel free to set its status to positive_review.
Last 10 new commits:
ab93aed | Merge branch 'fsm/cartesian-product-intersection' into fsm/process_output_new
|
75aa9e1 | corrected doctests (after change of output)
|
d18312e | Merge branch 'fsm/state_color' into fsm/process_output_new
|
2d43fdd | FiniteStateMachine: add failing doctests: non-hashable colors
|
547968a | FiniteStateMachine.product_FiniteStateMachine, composition: fix unhashable colors
|
d51be51 | Automaton.determinisation(): docstring on hashable colors
|
c5dd860 | Merge branch 'fsm/state_color' into fsm/process_output_new
|
70294bf | trac ticket number added
|
ed93dd3 | Minor changes during review.
|
3820c49 | corrected whitespaceerror
|
comment:8 Changed 9 years ago by
Status: | needs_review → positive_review |
---|
comment:9 Changed 9 years ago by
Dependencies: | #16128, #16061 → #16128, #16061, #15990 |
---|---|
Status: | positive_review → needs_review |
Does not merge on beta8.
comment:10 Changed 9 years ago by
Status: | needs_review → needs_work |
---|
comment:11 Changed 9 years ago by
Branch: | u/dkrenn/ticket/16132 → u/dkrenn/fsm_process_output_new-on-beta8 |
---|---|
Commit: | 3820c49851711ebffb12e230b27e9faad2d79b6d → a14dd81a113644263163eb69ba3b090f646e35a9 |
Status: | needs_work → needs_review |
Is now working on beta8. Please review changes.
Last 10 new commits:
75aa9e1 | corrected doctests (after change of output)
|
d18312e | Merge branch 'fsm/state_color' into fsm/process_output_new
|
2d43fdd | FiniteStateMachine: add failing doctests: non-hashable colors
|
547968a | FiniteStateMachine.product_FiniteStateMachine, composition: fix unhashable colors
|
d51be51 | Automaton.determinisation(): docstring on hashable colors
|
c5dd860 | Merge branch 'fsm/state_color' into fsm/process_output_new
|
70294bf | trac ticket number added
|
ed93dd3 | Minor changes during review.
|
3820c49 | corrected whitespaceerror
|
a14dd81 | Merge remote-tracking branch 'origin/u/dkrenn/ticket/16132' into fsm/process_output_new-on-beta8
|
comment:12 Changed 9 years ago by
Branch: | u/dkrenn/fsm_process_output_new-on-beta8 → u/cheuberg/fsm_process_output_new-on-beta8 |
---|
comment:13 follow-up: 14 Changed 9 years ago by
Commit: | a14dd81a113644263163eb69ba3b090f646e35a9 → afc15e590d313a04c2a2aedb67203994865908ee |
---|
Reviewed the above merge with develop, merge is fine, doctests pass.
Replaced two raise E, V by raise E(V) in the spirit of #15990 which had been merged previously.
comment:14 Changed 9 years ago by
comment:15 Changed 9 years ago by
Status: | needs_review → positive_review |
---|
comment:16 Changed 9 years ago by
Branch: | u/cheuberg/fsm_process_output_new-on-beta8 → afc15e590d313a04c2a2aedb67203994865908ee |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Last 10 new commits:
corrected one whitespace error
Transducer.cartesian_product: small correction in docstring
Merge branch 'fsm/cartesian-product-intersection' into fsm/process_output_new
corrected doctests (after change of output)
Merge branch 'fsm/state_color' into fsm/process_output_new
FiniteStateMachine: add failing doctests: non-hashable colors
FiniteStateMachine.product_FiniteStateMachine, composition: fix unhashable colors
Automaton.determinisation(): docstring on hashable colors
Merge branch 'fsm/state_color' into fsm/process_output_new
trac ticket number added