Opened 4 years ago

Closed 4 years ago

#16117 closed enhancement (fixed)

Thematic tutorial on algebraic combinatorics

Reported by: aschilling Owned by:
Priority: major Milestone: sage-6.2
Component: combinatorics Keywords: algebraic combinatorics, thematic tutorial
Cc: sage-combinat, tscrim, nthiery Merged in:
Authors: Anne Schilling Reviewers: Ralf Stephan, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0a563ab (Commits) Commit: 0a563abf2153b06652ff5bc6a8908091d110bc4b
Dependencies: Stopgaps:

Description

These are some Sage examples on algebraic combinatorics following Stanley's new book on "Algebraic Combinatorics: walks, trees, tableaux and more".

Change History (15)

comment:1 Changed 4 years ago by aschilling

  • Branch set to u/aschilling/16117/algebraic_combinatorics
  • Cc tscrim nthiery added
  • Commit set to 14a284a9fc11126019a18a9a52bfef7e9aa773b3

New commits:

14a284aStart of thematic tutorial for Stanley's new book "Algebraic combinatorics: Walks, trees, tableaux and more"

comment:2 Changed 4 years ago by git

  • Commit changed from 14a284a9fc11126019a18a9a52bfef7e9aa773b3 to 60221716e9a202c065cd0f16ae48e06c1e755885

Branch pushed to git repo; I updated commit sha1. New commits:

6022171More changes

comment:3 Changed 4 years ago by git

  • Commit changed from 60221716e9a202c065cd0f16ae48e06c1e755885 to d3bde73cee3d2fc964d3753e83920a29ceb95a2a

Branch pushed to git repo; I updated commit sha1. New commits:

d3bde73Added algebraic_combinatorics to doctree and started section on Tsetlin library

comment:4 Changed 4 years ago by git

  • Commit changed from d3bde73cee3d2fc964d3753e83920a29ceb95a2a to f384548b10ee1a33a818575f33b26891c771747b

Branch pushed to git repo; I updated commit sha1. New commits:

f384548finished Tsetlin library section

comment:5 Changed 4 years ago by aschilling

  • Status changed from new to needs_review

comment:6 follow-up: Changed 4 years ago by rws

  • Reviewers set to Ralf Stephan

Looks good, could not find a typo by eyeball, congratulations. I found it easy going and motivating. I cannot comment on correctness, so please someone look at that and give positive.

comment:7 in reply to: ↑ 6 Changed 4 years ago by aschilling

Replying to rws:

Looks good, could not find a typo by eyeball, congratulations. I found it easy going and motivating. I cannot comment on correctness, so please someone look at that and give positive.

Thank you for the quick review! It would be great if my students can see that what they are learning in class is already in Sage :-) !

comment:8 Changed 4 years ago by tscrim

  • Branch changed from u/aschilling/16117/algebraic_combinatorics to u/tscrim/16117-tutorial_alg_comb
  • Commit changed from f384548b10ee1a33a818575f33b26891c771747b to 05ab1d7a0382f690a34689b494c0a94662002b6b
  • Reviewers changed from Ralf Stephan to Ralf Stephan, Travis Scrimshaw

Hey Anne,

I've made a couple of changes:

  • removed tab characters,
  • some minor grammar corrections,
  • added a reference for Stanley's book and links in the tutorial,
  • added link to splay trees in Tsetlin library,
  • changed the format for edges in the digraph, and
  • other misc formatting tweaks.

If you're happy with my changes, then it's a positive review.


New commits:

bb182fdReview tweaks.
b5084d3Last 80 witdh char line breaks.
05ab1d7Added info about splay trees.

comment:9 follow-up: Changed 4 years ago by aschilling

  • Branch changed from u/tscrim/16117-tutorial_alg_comb to u/aschilling/16117/algebraic_combinatorics
  • Commit changed from 05ab1d7a0382f690a34689b494c0a94662002b6b to 35bb9401b27ea40f4aa7a9c377b5920698d55d14

New commits:

35bb940incorporated Travis' changes that I agree with

comment:10 in reply to: ↑ 9 Changed 4 years ago by aschilling

  • Status changed from needs_review to positive_review

Thanks for the review! I incorporated all comments I agree with.

Anne

comment:11 follow-up: Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Underscores are not valid identifiers in TeX:

! Missing $ inserted.
<inserted text> 
                $
l.18566 \bibitem[Bidigare_1997]{Bidigare_1997}
                                              {\phantomsection\label{algebra...

? 
! Emergency stop.

comment:12 Changed 4 years ago by git

  • Commit changed from 35bb9401b27ea40f4aa7a9c377b5920698d55d14 to 0a563abf2153b06652ff5bc6a8908091d110bc4b

Branch pushed to git repo; I updated commit sha1. New commits:

0a563abfixed references

comment:13 in reply to: ↑ 11 Changed 4 years ago by aschilling

Replying to vbraun:

Underscores are not valid identifiers in TeX:

! Missing $ inserted.
<inserted text> 
                $
l.18566 \bibitem[Bidigare_1997]{Bidigare_1997}
                                              {\phantomsection\label{algebra...

? 
! Emergency stop.

Thanks, that should be fixed now!

comment:14 Changed 4 years ago by aschilling

  • Status changed from needs_work to positive_review

comment:15 Changed 4 years ago by vbraun

  • Branch changed from u/aschilling/16117/algebraic_combinatorics to 0a563abf2153b06652ff5bc6a8908091d110bc4b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.