Opened 6 years ago

Closed 6 years ago

#16112 closed defect (fixed)

Let ATLAS build on Cygwin64

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.2
Component: porting: Cygwin Keywords: atlas days57 cygwin
Cc: Merged in:
Authors: Jean-Pierre Flori Reviewers: Sebastien Gouezel
Report Upstream: N/A Work issues:
Branch: 0018e26 (Commits) Commit: 0018e2649f65712c9a7e411fd72147b515039600
Dependencies: Stopgaps:

Description

A line I introduced in #14605 actually prevent ATLAS from building...

Change History (9)

comment:1 Changed 6 years ago by jpflori

  • Branch set to u/jpflori/ticket/16112
  • Commit set to 410649682b968f3607d3e8a27781db72ec9161a2
  • Status changed from new to needs_review

New commits:

4106496Let ATLAS build on Cygwin64.

comment:2 Changed 6 years ago by gouezel

  • Status changed from needs_review to needs_info

On cygwin64, atlas compiles if and only if the patch is applied.

However, it is not clear to me why the patch is necessary, since Win64 is a valid target for atlas. Could you explain if this is the right thing, or if this is a hack until some bugs are fixed upstream?

comment:3 Changed 6 years ago by jpflori

I'm not sure why this is needed. According to my tests:

  • it does not work with Win64 (in fact ATLAS fails to pick a working compiler IIRC...),
  • it does with WinNT.

I'm not sure what is involved in ATLAS build system which makes these differences. I don't really remember if I actually managed to build ATLAS with Win64 used. I fear I changed that after my successful builds because I just discovered that value and thought "oj this looks nice, let's put this in".

comment:4 Changed 6 years ago by jpflori

  • Status changed from needs_info to needs_review

(There are a lot of problems with ATLAS custom build system, I would not want to investigate that one myself.)

comment:5 Changed 6 years ago by gouezel

  • Status changed from needs_review to needs_work

OK, then could you add a comment in the code saying that Win64 seems more adequate for Cygwin64, but fails for unknown reasons due to ATLAS build system? It may be helpful in the future if ATLAS improves...

comment:6 Changed 6 years ago by git

  • Commit changed from 410649682b968f3607d3e8a27781db72ec9161a2 to 0018e2649f65712c9a7e411fd72147b515039600

Branch pushed to git repo; I updated commit sha1. New commits:

0018e26Add comment about not picking up Win64 as OS on Cygwin64.

comment:7 Changed 6 years ago by jpflori

  • Keywords atlas days57 cygwin added
  • Status changed from needs_work to needs_review

comment:8 Changed 6 years ago by gouezel

  • Reviewers set to Sebastien Gouezel
  • Status changed from needs_review to positive_review

comment:9 Changed 6 years ago by vbraun

  • Branch changed from u/jpflori/ticket/16112 to 0018e2649f65712c9a7e411fd72147b515039600
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.