Opened 7 years ago

Closed 6 years ago

#16106 closed task (fixed)

Delete deprecation warning in Transducer.cartesian_product

Reported by: skropf Owned by:
Priority: minor Milestone: sage-6.9
Component: finite state machines Keywords: finite_state_machine
Cc: dkrenn, cheuberg Merged in:
Authors: Sara Kropf, Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 24f7b3b (Commits, GitHub, GitLab) Commit: 24f7b3bca8846f551595dc5cd6864be61ad03e48
Dependencies: #16061 Stopgaps:

Status badges

Description (last modified by cheuberg)

Delete the deprecation warning and its documentation in Transducer.cartesian_product.

See #16061 for the reasons for this deprecation warning. The deprecation warning was active since #16061 was merged, i.e. in 6.2.beta8 (2014-04-14) and 6.2 (2014-05-06).

Change History (9)

comment:1 Changed 7 years ago by dkrenn

  • Branch changed from u/skropf/fsm/cartesian-product-intersection-no-deprecation to u/dkrenn/fsm/cartesian-product-intersection-no-deprecation
  • Commit changed from 0039d7dc4d65b366335396be2fd2fbdbe50d458a to 5f45124946b3cd5d02e53ed0f03484587f3ec399
  • Reviewers set to Daniel Krenn

I've reviewed this patch: I've deleted also the deprecated variable now. For me this is a positive review, so set it to positive_review in May 2015.


New commits:

0039d7dTransducer.cartesian_product: deprecation warning deleted
5f45124removed also deprecated variable

comment:2 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:3 Changed 7 years ago by cheuberg

  • Component changed from combinatorics to finite state machines

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 6 years ago by cheuberg

  • Authors changed from Sara Kropf to Sara Kropf, Clemens Heuberger
  • Branch changed from u/dkrenn/fsm/cartesian-product-intersection-no-deprecation to u/cheuberg/fsm/cartesian-product-intersection-no-deprecation
  • Milestone changed from sage-6.4 to sage-6.9

comment:6 Changed 6 years ago by git

  • Commit changed from 5f45124946b3cd5d02e53ed0f03484587f3ec399 to 24f7b3bca8846f551595dc5cd6864be61ad03e48

Branch pushed to git repo; I updated commit sha1. New commits:

4a83285Merge tag '6.8' into fsm/cartesian-product-intersection-no-deprecation
24f7b3bTrac #16106: remove further occurrences of FSMOldCodeTransducerCartesianProduct

comment:7 Changed 6 years ago by cheuberg

  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Deleted deprecation warning in Transducer.cartesian_product to Delete deprecation warning in Transducer.cartesian_product

comment:8 Changed 6 years ago by dkrenn

  • Status changed from needs_review to positive_review

comment:9 Changed 6 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/cartesian-product-intersection-no-deprecation to 24f7b3bca8846f551595dc5cd6864be61ad03e48
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.