Opened 8 years ago

Closed 8 years ago

#16084 closed defect (fixed)

matplotlib dependency on pkgconf

Reported by: vbraun Owned by:
Priority: blocker Milestone: sage-6.2
Component: packages: standard Keywords: days57
Cc: ppurka, fbissey, kcrisman, slabbe Merged in:
Authors: Volker Braun Reviewers: John Palmieri, Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: 126c84e (Commits, GitHub, GitLab) Commit: 126c84e0d4ddb9b0dfd770d8f2136fa709c32130
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

The matplotlib dependency is wrong, this is probably the reason for the build failure on old OSX versions where it fails to find freetype. If you build serial / almost serial then pkgconf is not build before matplotlib. On highly parallel builds, pkgconf finishes much before matplotlib is started.

Change History (13)

comment:1 Changed 8 years ago by vbraun

  • Branch set to u/vbraun/matplotlib_dependency_on_pkgconf

comment:2 Changed 8 years ago by vbraun

  • Authors set to Volker Braun
  • Cc ppurka fbissey kcrisman added
  • Commit set to 126c84e0d4ddb9b0dfd770d8f2136fa709c32130
  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

126c84eMatplotlib depends on pkgconf, not the pkgconfig python module

comment:3 Changed 8 years ago by vbraun

  • Cc slabbe added

comment:4 Changed 8 years ago by vbraun

  • Priority changed from major to blocker

comment:5 Changed 8 years ago by vbraun

  • Keywords days57 added

comment:6 Changed 8 years ago by kcrisman

See also #16047. Thanks for tracking this down - was this simply a typo, then, in some sense? Interesting. Some people may also do serial builds due to heavy load or forgetting to set env vars, so this is good in any case.

comment:7 Changed 8 years ago by vbraun

Yes, I was talking to Sebastien about #16047. I did a serial install and it worked with this ticket.

comment:8 Changed 8 years ago by jhpalmieri

It's probably my fault. I think I read the descriptions of the pkgconf and pkgconfig packages and assumed, based on those, that pkgconfig would have pkgconf as a dependency. But it doesn't.

comment:9 Changed 8 years ago by vbraun

pkgconf isn't a build-time dependency for the pkgconfig python library afaik. Only runtime.

comment:10 Changed 8 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

I see the same as above: make build-serial failed without this because matplotlib tried to build with only pkgconfig, not pkgconf. With this, make build-serial worked.

comment:11 Changed 8 years ago by slabbe

  • Reviewers changed from John Palmieri to John Palmieri, Sébastien Labbé

Doing sage -f pkgconf then make (serial) again allowed me to complete the compilation of beta6. So I confirm that the bug I reported on sage-release is fixed by adding pkgconf as a dependency to matplotlib. For removing pkgconfig as a dependency for matplotlib, I can't say anything but John does. So positive review!

John beated me for the positive review because I lost some time while preparing and eating Pâté chinois at Sage Days 57:)

comment:12 Changed 8 years ago by fbissey

And it got right past me when I was looking at original matplotlib upgrade ticket. Didn't notice one bit.

comment:13 Changed 8 years ago by vbraun

  • Branch changed from u/vbraun/matplotlib_dependency_on_pkgconf to 126c84e0d4ddb9b0dfd770d8f2136fa709c32130
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.