Opened 7 years ago

Closed 6 months ago

Last modified 6 months ago

#16072 closed enhancement (worksforme)

Python 3 preparation: integer types

Reported by: wluebbe Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: python3 Keywords: python3
Cc: chapoton, mkoeppe, tscrim Merged in:
Authors: Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Python 2 has two integer types int and long. In Python 3, int is gone and long is renamed int.

The tool 2to3 simply renames long to int.

There are 72 affected modules.

This ticket is tracked as a dependency of meta-ticket ticket:16052.

Tickets: #24221, #24225, #24227, #24244, #24247, #24248.

Change History (15)

comment:1 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:2 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:3 Changed 5 years ago by jdemeyer

  • Component changed from distribution to python3

comment:4 Changed 4 years ago by chapoton

  • Milestone changed from sage-6.4 to sage-8.0

one step done in #22871

comment:5 Changed 3 years ago by chapoton

more steps in #24155 and #24218

comment:6 Changed 3 years ago by chapoton

after which there remains 

git grep -c "^[^#:]*[^_la]long(" *.py
src/sage/interfaces/fricas.py:1
src/sage/interfaces/gp.py:1
src/sage/interfaces/interface.py:2
src/sage/misc/sage_input.py:3
src/sage/rings/finite_rings/element_ext_pari.py:1
src/sage/rings/polynomial/polynomial_quotient_ring_element.py:1
src/sage/rings/quotient_ring_element.py:1

among which 

src/sage/misc/sage_input.py:3

is only in doctests

Last edited 3 years ago by chapoton (previous) (diff)

comment:7 Changed 3 years ago by jdemeyer

  • Cc chapoton embray added
  • Description modified (diff)

Adding some tickets.

comment:8 Changed 3 years ago by slelievre

Should the ticket summary say 'The Py2 type "long" is gone in Py3' rather than 'The Py3 type "long" is gone in Py3'?

comment:9 Changed 3 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Python 3 preparation: The Py3 type "long" is gone in Py3 to Python 3 preparation: integer types

comment:10 Changed 3 years ago by chapoton

new state of affairs on 8.2.b3 

src/mac-app/tools/createDSStore/mac_alias/alias.py:2
src/sage/interfaces/fricas.py:1
src/sage/interfaces/gp.py:1
src/sage/interfaces/interface.py:1
src/sage/misc/sage_input.py:3
src/sage/rings/polynomial/polynomial_quotient_ring_element.py:1
src/sage/rings/quotient_ring_element.py:1

comment:11 Changed 3 years ago by chapoton

see #24559

comment:12 Changed 6 months ago by chapoton

  • Cc mkoeppe tscrim added; embray removed
  • Milestone changed from sage-8.0 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

shall we close this one ?

comment:13 Changed 6 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:14 Changed 6 months ago by chapoton

  • Resolution set to invalid
  • Status changed from positive_review to closed

comment:15 Changed 6 months ago by embray

  • Resolution changed from invalid to worksforme
Note: See TracTickets for help on using tickets.