Opened 8 years ago

Closed 8 years ago

#16062 closed enhancement (fixed)

DiGraph.is_aperiodic: new method (wraps networkx method)

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.2
Component: graph theory Keywords: digraph
Cc: dkrenn Merged in:
Authors: Clemens Heuberger Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: f4a0659 (Commits, GitHub, GitLab) Commit: f4a0659b521591f8fb875220926830d9e5b7eb77
Dependencies: Stopgaps:

Status badges


This simply wraps the networkx method of the same method, but wrapping it may help to find the function in the sage documentation. Furthermore, other code calling DiGraph?.is_aperiodic would benefit from eventual other implementations for other backends.

Change History (5)

comment:1 Changed 8 years ago by cheuberg

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by ncohen

Looks good. Could you add a link toward in the doc ?

comment:3 Changed 8 years ago by git

  • Commit changed from 8fb41df8c34f8fae98784abf60e6d27121f1dbb9 to f4a0659b521591f8fb875220926830d9e5b7eb77

Branch pushed to git repo; I updated commit sha1. New commits:

f4a0659DiGraph.is_aperiodic: Add Wikipedia link to docstring

comment:4 Changed 8 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

OKayyyyyyyyyyy !


comment:5 Changed 8 years ago by vbraun

  • Branch changed from u/cheuberg/digraph/is_aperiodic to f4a0659b521591f8fb875220926830d9e5b7eb77
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.