Changes between Version 27 and Version 44 of Ticket #16045


Ignore:
Timestamp:
08/22/17 14:33:40 (4 years ago)
Author:
jipilab
Comment:

I disagree. This should not be treated here, but a new ticket should be opened. If we proceed as you propose (and everybody else does the same), this random pynormaliz bug will be treated in every ticket that is around.

In fact it already seems to be fixed here:

https://trac.sagemath.org/ticket/23586

see also:

https://trac.sagemath.org/ticket/23637

and

https://git.sagemath.org/sage.git/diff?id2=effcedba414f8832b07e6e77cf0b4a6aed6aff9b&id=cb2fcfd6760f74db9dc16def7edfef00c96cf657

All right, good to know, thanks for looking it up!

Should we add a dependancy in such cases, or perhaps just wait...?

I corrected two indentations. This looks good to me now, tests pass on my machine with pynormaliz (!).

I extended the description of the ticket a bit, if you believe it should contain some more information you can add it, otherwise, I'd it is ready to go.


New commits:

2b0fb6dMerge branch 'u/moritz/16045' of git://trac.sagemath.org/sage into 16045
f5d47cfCorrected some indentations

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16045

    • Property Status changed from needs_info to positive_review
    • Property Reviewers changed from to Jean-Philippe Labbé
    • Property Branch changed from u/moritz/16045 to u/jipilab/16045
    • Property Keywords days88 added
    • Property Commit changed from 1f64267248f427828b1d0225b947086b8540e619 to f5d47cf5576ca2f752aaac47f859b2c997535af3
  • Ticket #16045 – Description

    v27 v44  
    1919
    2020(Note: The lrs allows calculation of volumes of facets without reducing the dimension of the ambient space, but it uses non-isometrical projections!)
     21
     22The suggested resolution adds a parameter `measure` that essentially behaves as follows:
     23
     24{{{
     25sage: P = Polyhedron([[0, 0], [1, 1]])
     26sage: P.volume()
     270
     28sage: P.volume(measure='induced')                                                                                                                                   
     29sqrt(2)
     30sage: P.volume(measure='induced_rational') # optional -- latte_int
     311
     32}}}