Opened 6 years ago

Closed 6 years ago

#16041 closed defect (fixed)

Get git to build on OS X 10.4 PPC

Reported by: kcrisman Owned by:
Priority: blocker Milestone: sage-6.2
Component: packages: standard Keywords:
Cc: vbraun Merged in:
Authors: Karl-Dieter Crisman, Volker Braun Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 57d264b (Commits) Commit: 57d264ba967902e726fb3bd8d62cb8335f4f9336
Dependencies: Stopgaps:

Description

As in the summary.

    CC http-backend.o
    LINK git-http-backend
/usr/bin/ld: warning multiple definitions of symbol _regcomp
libgit.a(regex.o) definition of _regcomp in section (__TEXT,__text)
/usr/lib/libSystem.dylib(regcomp.So) definition of _regcomp
/usr/bin/ld: warning multiple definitions of symbol _regexec
libgit.a(regex.o) definition of _regexec in section (__TEXT,__text)
/usr/lib/libSystem.dylib(regexec.So) definition of _regexec
/usr/bin/ld: warning multiple definitions of symbol _regfree
libgit.a(regex.o) definition of _regfree in section (__TEXT,__text)
/usr/lib/libSystem.dylib(regfree.So) definition of _regfree
    CC imap-send.o
imap-send.c:33:37: fatal error: CommonCrypto/CommonHMAC.h: No such file or directory
compilation terminated.
make[3]: *** [imap-send.o] Error 1
Error building git.

real    9m46.658s
user    5m48.673s
sys     1m46.609s
************************************************************************
Error installing package git-1.8.4.4
************************************************************************

Volker says this macports ticket has the fix, which seems reasonable.

  • trunk/dports/devel/git-core/Portfile

    a b  
    202202}
    203203
     204platform darwin 8 {
     205    build.args-append   NO_APPLE_COMMON_CRYPTO=1
     206}
     207
    204208default_variants    +doc +pcre +credential_osxkeychain

Change History (5)

comment:1 Changed 6 years ago by kcrisman

Sorry, this means we have to add this to the flags. I'll try something kludgy like adding

export NO_APPLE_COMMON_CRYPTO=1

in my own to try this out, but presumably we would want to do a case for Darwin 8 in spkg-install.

comment:2 Changed 6 years ago by kcrisman

  • Cc vbraun added
  • Priority changed from major to blocker

Yes, this works. In spkg-install, do

if { uname -sr | grep 'Darwin 8' ;} &>/dev/null; then
    export NO_APPLE_COMMON_CRYPTO=1
fi

I can't turn this into a branch yet on that machine, I don't think - at least, sage -git diff hangs - but I'll gladly approve this if someone does. This shouldn't affect any other platform than Tiger, since we don't support Panther and anything after this supports this common crypto thingie.

Putting as blocker since fix is here and prevents building.

comment:3 Changed 6 years ago by kcrisman

  • Authors set to Karl-Dieter Crisman, Volker Braun
  • Branch set to u/kcrisman/osx-tiger-git
  • Commit set to 57d264ba967902e726fb3bd8d62cb8335f4f9336
  • Status changed from new to needs_review

Okay, I did this change on my other machine. Needs review.


New commits:

57d264bAdd flag keeping Mac Tiger (Darwin 8) from using Common Crypto so builds

comment:4 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:5 Changed 6 years ago by vbraun

  • Branch changed from u/kcrisman/osx-tiger-git to 57d264ba967902e726fb3bd8d62cb8335f4f9336
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.