Opened 8 years ago

Closed 8 years ago

#16036 closed defect (fixed)

Fix corner cases of latex for partitions

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-6.2
Component: combinatorics Keywords:
Cc: sage-combinat, aschilling, zabrocki, andrew.mathas Merged in:
Authors: Travis Scrimshaw Reviewers: Mike Zabrocki
Report Upstream: N/A Work issues:
Branch: 80719ef (Commits, GitHub, GitLab) Commit: 80719efe03b09c6a4537b1b9105283f7b5dce854
Dependencies: Stopgaps:

Status badges

Description

sage: Partitions.global_options('exp_high')
sage: latex(Partition([])) # Boom
sage: Partitions.global_options('exp_low')
sage: latex(Partition([])) # Returns the empty string

There are likely others.

Change History (10)

comment:1 Changed 8 years ago by tscrim

  • Branch set to public/combinat/fix_latex_partitions-16036
  • Cc andrew.mathas added
  • Commit set to 0903e18e9c897f350a67ad4b436e11124f1bf957
  • Status changed from new to needs_review

Andrew, just to let you know, I've also changed the repr output for exp of partitions:

sage: print Partition([])._repr_exp_low()
-
sage: print Partition([])._repr_compact_low()
-

New commits:

0903e18Fix some corner cases for partitions and partition tuples.

comment:2 Changed 8 years ago by zabrocki

The one case that prints nothing for an empty partition is global_options(display="diagram")

sage: Partition([])._repr_diagram()
''

Is this what you wanted? PartitionTuple displays - for an empty partition. Otherwise, I've had a look, tested as much as I could, and am willing to set to positive review.

comment:3 Changed 8 years ago by git

  • Commit changed from 0903e18e9c897f350a67ad4b436e11124f1bf957 to 80719efe03b09c6a4537b1b9105283f7b5dce854

Branch pushed to git repo; I updated commit sha1. New commits:

2e4acefMerge branch 'develop' into public/combinat/fix_latex_partitions-16036
80719efAdded special case to ferrers diagram for the empty partition.

comment:4 Changed 8 years ago by tscrim

Good point. Probably best to display something.

comment:5 Changed 8 years ago by tscrim

FTR I've made the change in my previous commit.

comment:6 Changed 8 years ago by zabrocki

  • Status changed from needs_review to positive_review

It looks good to me.

comment:7 Changed 8 years ago by tscrim

Thanks for doing the review Mike.

comment:8 Changed 8 years ago by vbraun

reviewer name

comment:9 Changed 8 years ago by tscrim

  • Reviewers set to Mike Zabrocki

comment:10 Changed 8 years ago by vbraun

  • Branch changed from public/combinat/fix_latex_partitions-16036 to 80719efe03b09c6a4537b1b9105283f7b5dce854
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.