Opened 8 years ago

Closed 8 years ago

#16024 closed defect (fixed)

incorrect deleting of states in finite state machine

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.2
Component: combinatorics Keywords: finite state machine
Cc: cheuberg, skropf Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: 10bfe49 (Commits, GitHub, GitLab) Commit: 10bfe492f9fd4b83692c77b8719305a3703ea433
Dependencies: Stopgaps:

Status badges

Description 

            sage: from sage.combinat.finite_state_machine import FSMTransition
            sage: t1 = FSMTransition('A', 'B', 0)
            sage: t2 = FSMTransition('B', 'B', 1)
            sage: F = FiniteStateMachine([t1, t2])
            sage: F.delete_state('A')
            sage: F.transitions()
            [Transition from 'B' to 'B': 1|-]
            sage: F._states_
            ['B']
            sage: F._states_dict_
            {'A': 'A', 'B': 'B'}

The last output is wrong.

Change History (6)

comment:1 Changed 8 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Branch set to u/dkrenn/ticket/16024
  • Cc cheuberg skropf added
  • Commit set to 35cea28d10dcb54bc1645c6d39778f55718392bb
  • Status changed from new to needs_review

New commits:

​35cea28Trac #16024: fixed incorrect deleting of states in finite state machine

comment:2 Changed 8 years ago by cheuberg

  • Branch changed from u/dkrenn/ticket/16024 to u/cheuberg/ticket/16024
  • Created changed from 03/27/14 17:30:12 to 03/27/14 17:30:12
  • Modified changed from 03/27/14 17:35:19 to 03/27/14 17:35:19

comment:3 Changed 8 years ago by cheuberg

  • Commit changed from 35cea28d10dcb54bc1645c6d39778f55718392bb to 10bfe492f9fd4b83692c77b8719305a3703ea433
  • Reviewers set to Clemens Heuberger

reviewed original changes and added a minor modification in the docstring.

comment:4 Changed 8 years ago by dkrenn

I've cross-reviewed your changes. For me those are a positive-review.

comment:5 Changed 8 years ago by cheuberg

  • Status changed from needs_review to positive_review

comment:6 Changed 8 years ago by vbraun

  • Branch changed from u/cheuberg/ticket/16024 to 10bfe492f9fd4b83692c77b8719305a3703ea433
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.