Opened 7 years ago

Closed 7 years ago

#16020 closed defect (fixed)

Graph - LateX output in notebook

Reported by: elixyre Owned by:
Priority: major Milestone: sage-6.2
Component: graph theory Keywords: LateX, Graph
Cc: ncohen, tscrim, aschilling Merged in:
Authors: Jean-Baptiste Priez Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 8f8b8ef (Commits) Commit: 8f8b8efca33fe3274bd69fc6889a0a36dce6ca8b
Dependencies: Stopgaps:

Description

I propose a simple patch to see the latex output in the notebook.

Change History (12)

comment:1 Changed 7 years ago by elixyre

  • Branch set to u/elixyre/ticket/16020
  • Commit set to 05e9f242210952b45e7f64a72806c82f7919cdc2

New commits:

05e9f24Add tikz to the latex preamble of mathjax (notebook)

comment:2 Changed 7 years ago by elixyre

  • Status changed from new to needs_review

comment:3 Changed 7 years ago by ncohen

  • Branch changed from u/elixyre/ticket/16020 to public/16020
  • Commit changed from 05e9f242210952b45e7f64a72806c82f7919cdc2 to a7b4136fdeb55542d519925a25ec248a28d47be6
  • Reviewers set to Nathann Cohen

Okay.... Well, despite what I told you by email earlier, it can also help to visualize my cherished hypergraphs.

sage: view(Hypergraph([[1,2,3],[2,3,4],[1,4,5]]))

I did the same modification to the Hypergraph class. If you agree with it, you can set this ticket to positive_review.

Thanks !

Nathann


New commits:

a7b4136trac #16020: Reviewer's patch

comment:4 Changed 7 years ago by elixyre

  • Status changed from needs_review to positive_review

Thanks Nathann!

comment:5 Changed 7 years ago by vbraun

  • Status changed from positive_review to needs_work

Doctest failures:

sage -t --long src/doc/de/tutorial/latex.rst
**********************************************************************
File "src/doc/de/tutorial/latex.rst", line 445, in doc.de.tutorial.latex
Failed example:
    latex.mathjax_avoid_list()
Expected:
    ['tikzpicture']
Got:
    ['tikz', 'tikzpicture']
**********************************************************************

comment:6 Changed 7 years ago by git

  • Commit changed from a7b4136fdeb55542d519925a25ec248a28d47be6 to 743cca902c89381863d7164ecaaca233c9bbba0c

Branch pushed to git repo; I updated commit sha1. New commits:

a63dee2Merge branch 'public/16020' of ssh://trac.sagemath.org:22/sage into 16020
743cca9trac #16020 doctest in german tuto

comment:7 Changed 7 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:8 Changed 7 years ago by tscrim

  • Cc tscrim aschilling added

comment:9 Changed 7 years ago by git

  • Commit changed from 743cca902c89381863d7164ecaaca233c9bbba0c to 8f8b8efca33fe3274bd69fc6889a0a36dce6ca8b

Branch pushed to git repo; I updated commit sha1. New commits:

8f8b8efFixed similar failures in other language latex tutorials.

comment:10 Changed 7 years ago by tscrim

I confirmed that this keeps the dot2tex graph working and also has them work OOTB in the notebook (last time I tried this, which was a long time ago (6 months), it didn't work).

I fixed the same doctest for the other latex tutorials in French and English. So someone double-check and then set a pos_rev.

Last edited 7 years ago by tscrim (previous) (diff)

comment:11 Changed 7 years ago by ncohen

  • Status changed from needs_review to positive_review

Still looks good !

Nathann

comment:12 Changed 7 years ago by vbraun

  • Branch changed from public/16020 to 8f8b8efca33fe3274bd69fc6889a0a36dce6ca8b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.