Opened 7 years ago

Closed 7 years ago

#16019 closed defect (fixed)

Connected components for immutable digraphs does not work

Reported by: tscrim Owned by: tscrim
Priority: major Milestone: sage-6.2
Component: graph theory Keywords:
Cc: ncohen Merged in:
Authors: Nathann Cohen Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 7635a24 (Commits) Commit: 7635a242ddb16f4e70b2df2d08da6dc3f0d75f4d
Dependencies: Stopgaps:

Description (last modified by ncohen)

sage: G = DiGraph([[1,2]])
sage: G.connected_components()
[[1, 2]]
sage: G.copy(immutable=True).connected_components()
AttributeError: 'NoneType' object has no attribute 'out_neighbors'

Change History (5)

comment:1 Changed 7 years ago by tscrim

  • Description modified (diff)

comment:2 Changed 7 years ago by ncohen

  • Description modified (diff)

comment:3 Changed 7 years ago by ncohen

  • Authors set to Nathann Cohen
  • Branch set to u/ncohen/16019
  • Commit set to 7635a242ddb16f4e70b2df2d08da6dc3f0d75f4d
  • Status changed from new to needs_review


That's the best I can do, and I am not proud of it ^^;


P.S. : You are the one at fault, actually. Who the hell computes connected components on digraphs ? It does not make any sense ! :-P

New commits:

7635a24trac #16019: Broken Connected Components for immutable digraphs

comment:4 Changed 7 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM. Thanks Nathann.

It came up with Dynkin diagrams (which slightly abuses DiGraph) and connected components correspond to irreducible types.

comment:5 Changed 7 years ago by vbraun

  • Branch changed from u/ncohen/16019 to 7635a242ddb16f4e70b2df2d08da6dc3f0d75f4d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.