Changes between Version 3 and Version 4 of Ticket #16004, comment 89


Ignore:
Timestamp:
10/17/14 17:41:51 (7 years ago)
Author:
kcrisman
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16004, comment 89

    v3 v4  
    44 * The "make new cell interface" icons look much better than before, but it is STILL a different color from before and a different cell height.  In particular, the commit https://github.com/vbraun/sagenb/commit/8fe8371b93112d29a4096307d5807d736c41e415 breaks it, and https://github.com/vbraun/sagenb/commit/f9760a8635a63511731e340046711b1a7288de1c "fixes" it but not really.
    55 * Shift-click is still broken, because Volker just took your commits but didn't fix them.  See https://github.com/kcrisman/sagenb/commit/4fe29c8f7ab6ae5a44bf9a51872b3008ee4d18a2 for a commit that (perhaps with minor modifications) fix this - I think I actually got it from Jonathan but perhaps modified it, that was a while ago now.
    6  * The new cell bar, when it is ''above'' a text area, does not have the icons.  In addition (and this is very, very minor), the very final new cell bar is not indented (presumably it is in a different div or something).
     6 * The new cell bar, when it is ''above'' a text area, does not have the icons.  In such cases, it also does not work. 
     7 * In addition (and this is very, very minor), the very final new cell bar is not indented (presumably it is in a different div or something).
    78
    89Please do check out what I did to keep behavior as close to the legacy as possible.  Hopefully it will be pretty easy for one of you to just import 'correct' behavior.  It would have been easier to have not touched that stuff at all, but I know that ship has sailed.  Also, if we need to move discussion to github that is fine, I'm putting it here because I know everyone is reading this :)