Opened 6 years ago

Closed 6 years ago

#15988 closed enhancement (fixed)

Python 3 preparation: Add missing parentheses in list comprension

Reported by: wluebbe Owned by:
Priority: major Milestone: sage-6.2
Component: distribution Keywords: python3
Cc: Merged in:
Authors: Wilfried Luebbe Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 9e13542 (Commits) Commit: 9e13542f08d1ced28e74a80fe8152f5485a22b4a
Dependencies: Stopgaps:

Description

Python 3 has stricter requirements for parentheses around tuples in list comprehension.

Changes according to lib2to3/fixes/fix_paren.py:

e.g. converts ``[x for x in 1, 2]`` to ``[x for x in (1, 2)]``

This ticket is tracked as a dependency of meta-ticket ticket:15980.

Change History (3)

comment:1 Changed 6 years ago by wluebbe

  • Branch set to u/wluebbe/ticket/15988
  • Commit set to 9e13542f08d1ced28e74a80fe8152f5485a22b4a
  • Status changed from new to needs_review
./sage -t -p --all --long --logfile=logs/ptestlong-15988.log
All tests passed!

New commits:

9e13542add missing parenthesis in 2 modules for Python 3 compatibility

comment:2 Changed 6 years ago by tscrim

  • Authors set to Wilfried Luebbe
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 6 years ago by vbraun

  • Branch changed from u/wluebbe/ticket/15988 to 9e13542f08d1ced28e74a80fe8152f5485a22b4a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.