Opened 7 years ago
Closed 6 years ago
#15977 closed defect (fixed)
Fix formatting for symbolic summation algorithms
Reported by: | kcrisman | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.4 |
Component: | documentation | Keywords: | |
Cc: | Merged in: | ||
Authors: | Karl-Dieter Crisman | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | ba7a100 (Commits) | Commit: | ba7a10024eeecc95730c1a406fcea54f40f0a34c |
Dependencies: | Stopgaps: |
Description
The formatting for the algorithm options for symbolic summation, e.g. here, is wrong.
Change History (16)
comment:1 Changed 7 years ago by
- Branch set to u/kcrisman/ticket/15977
- Created changed from 03/20/14 03:00:57 to 03/20/14 03:00:57
- Modified changed from 03/20/14 03:00:57 to 03/20/14 03:00:57
comment:2 Changed 7 years ago by
- Commit set to d54e8d624bf276bc649c55c0a5f10105b7378630
- Status changed from new to needs_review
comment:3 Changed 7 years ago by
- Branch changed from u/kcrisman/ticket/15977 to public/ticket/15977
- Commit changed from d54e8d624bf276bc649c55c0a5f10105b7378630 to 4db919e1e824a650ff0f34e896641baf95b7f289
This looks good to me. I have taken the opportunity to correct a few links to trac using the :trac:`1234`
syntax. If you agree with my changes, you can set this to positive review.
New commits:
c805cad | Merge branch 'u/kcrisman/ticket/15977' of ssh://trac.sagemath.org:22/sage into 15977
|
4db919e | trac #15977 corrected links to trac
|
comment:4 Changed 7 years ago by
I like everything about your changes except the following. (I had actually thought about doing this but figured I'd not want to cause merge issues and also save for another ticket - but hey, here you've done it!)
- # verify that this operation does not modify the passed dictionary (#6622) + Verify that this operation does not modify the passed dictionary (:trac:`6622`):: +
This is fine, but needs to be dedented. Note how it's exactly at the same indentation level as the immediately following doctest.
comment:5 Changed 7 years ago by
Damn, this is going to conflict with #11840, which should probably go in first.
comment:6 Changed 7 years ago by
- Commit changed from 4db919e1e824a650ff0f34e896641baf95b7f289 to d8e2ba1b7a3f3f00545439468b0eb1bafffde60c
Branch pushed to git repo; I updated commit sha1. New commits:
d8e2ba1 | trac #15977 correction of one indentation
|
comment:7 Changed 7 years ago by
- Commit changed from d8e2ba1b7a3f3f00545439468b0eb1bafffde60c to b037292bf8a68d15bdcc7998f7bf5ad1597e345d
Branch pushed to git repo; I updated commit sha1. New commits:
b037292 | Merge branch 'public/ticket/15977' of ssh://trac.sagemath.org:22/sage into 15977
|
comment:8 Changed 7 years ago by
ok, I have solved the conflicts with #11840, and it seems to be good to go. Please double check and put into positive review if you want.
comment:9 Changed 7 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:10 Changed 7 years ago by
- Reviewers set to Frédéric Chapoton
comment:11 Changed 6 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:12 Changed 6 years ago by
Not sure why this has conflicts (branch is red), but I think this should be okay now other than that.
comment:13 Changed 6 years ago by
- Status changed from needs_review to needs_work
comment:14 Changed 6 years ago by
- Commit changed from b037292bf8a68d15bdcc7998f7bf5ad1597e345d to ba7a10024eeecc95730c1a406fcea54f40f0a34c
Branch pushed to git repo; I updated commit sha1. New commits:
ba7a100 | Merge branch 'public/ticket/15977' of ssh://trac.sagemath.org:22/sage into 15977
|
comment:15 Changed 6 years ago by
- Status changed from needs_work to positive_review
looks good to me. I allow myself to give a positive review..
comment:16 Changed 6 years ago by
- Branch changed from public/ticket/15977 to ba7a10024eeecc95730c1a406fcea54f40f0a34c
- Resolution set to fixed
- Status changed from positive_review to closed
I haven't been able to actually try this because I've destroyed my Sage install somehow... but hopefully this will be good.
New commits:
Fixing formatting of the algorithm options for symbolic sums