Opened 7 years ago
Last modified 6 years ago
#15974 new enhancement
Implement hyperbolic Cartan types
Reported by:  tscrim  Owned by:  sagecombinat 

Priority:  minor  Milestone:  sage6.8 
Component:  combinatorics  Keywords:  hyperbolic root systems, coxeter 
Cc:  sagecombinat, nthiery, aschilling, bsalisbury1, bump, jipilab, vripoll  Merged in:  
Authors:  Travis Scrimshaw  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  public/combinat/root_systems/hyperbolic15974 (Commits)  Commit:  be1375dc6fab554fd8a9e4db3aa2dab6a1264ad3 
Dependencies:  Stopgaps: 
Description (last modified by )
They are a important class of indeterminate Cartan types. They will be given in terms of the table given in Classification of hyperbolic Dynkin diagrams, root lengths, and Weyl group orbits by Carbone, Chung, Cobbs, McRae, Nandi, Naqvi, and Penta (http://arxiv.org/abs/1003.0564), as well as in some of the other notations specified in the aforementioned paper.
Change History (13)
comment:1 Changed 7 years ago by
 Cc bump added
 Description modified (diff)
comment:2 Changed 7 years ago by
 Keywords coxeter added
comment:3 Changed 7 years ago by
 Branch set to public/combinat/root_systems/hyperbolic15974
 Commit set to cd151340b52b7289169e0967b058eb708e5dcf0c
comment:4 Changed 7 years ago by
 Description modified (diff)
comment:5 Changed 7 years ago by
 Cc jipilab added
comment:6 Changed 7 years ago by
 Commit changed from cd151340b52b7289169e0967b058eb708e5dcf0c to ae6d01cefde50ef11cc83f13324a2b3ee7d61f66
Branch pushed to git repo; I updated commit sha1. New commits:
ae6d01c  Merge branch 'develop' into public/combinat/root_systems/hyperbolic15974

comment:7 Changed 7 years ago by
Hi Travis!
Just a quick suggestion for less duplication in the code and a better isolation of the "database" part. Make:
if index == 1: dd = CartanType_Rank3Cycle._construct_dynkin_diagram((1,1,2)) elif index == 2: dd = CartanType_Rank3Cycle._construct_dynkin_diagram((1,1,22)) elif index == 3: dd = CartanType_Rank3Cycle._construct_dynkin_diagram((1,1,3)) ...
Into, at the start of the file and with a more specific name than data if possible:
data = (None, (1,1,2), (1,1,22), (1,1,3), ...)
And in the constructor:
dd = CartanType_Rank3Cycle._construct_dynkin_diagram(data[i])
Cheers,
Nicolas
comment:8 Changed 7 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:9 Changed 7 years ago by
 Commit changed from ae6d01cefde50ef11cc83f13324a2b3ee7d61f66 to d170a5794b6e59185a9503c5dc03a23a26358e30
Branch pushed to git repo; I updated commit sha1. New commits:
a807b5f  Merge branch 'public/combinat/root_systems/hyperbolic15974' of trac.sagemath.org:sage into public/combinat/root_systems/hyperbolic15974

8748c79  Merge branch 'develop' into public/combinat/root_systems/hyperbolic15974

d170a57  Replaced Lorentzian with hyperbolic.

comment:10 Changed 6 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:11 Changed 6 years ago by
 Cc vripoll added
comment:12 Changed 6 years ago by
 Commit changed from d170a5794b6e59185a9503c5dc03a23a26358e30 to be1375dc6fab554fd8a9e4db3aa2dab6a1264ad3
Branch pushed to git repo; I updated commit sha1. New commits:
be1375d  Merge branch 'public/combinat/root_systems/hyperbolic15974' of trac.sagemath.org:sage into public/combinat/root_systems/hyperbolic15974

comment:13 Changed 6 years ago by
 Milestone changed from sage6.4 to sage6.8
Current WIP version (I'm not guaranteeing anything to really work, nor for the structure to not change).
Last 10 new commits:
Refactoring hyperbolic types and added Lorentzian types.
More work on Lorentzian Cartan types.
Moved type E Lorentzian to separate file, started rank 3 hyperbolic types.
More work on hyperbolic root systems.
Merge branch 'develop' into public/combinat/root_systems/hyperbolic15974
Implemented marked Cartan types and refactored common code.
Fixed last doctests and added to full coverage.
Fixed last failing doctest.
Merge branch 'public/combinat/root_systems/marked_types15948' into public/combinat/root_systems/hyperbolic15974
Merge branch 'develop' into public/combinat/root_systems/hyperbolic15974