Opened 9 years ago

Last modified 7 years ago

#15974 new enhancement

Implement hyperbolic Cartan types

Reported by: Travis Scrimshaw Owned by: Sage Combinat CC user
Priority: minor Milestone: sage-6.8
Component: combinatorics Keywords: hyperbolic root systems, coxeter
Cc: Sage Combinat CC user, Nicolas M. Thiéry, Anne Schilling, Ben Salisbury, Daniel Bump, Jean-Philippe Labbé, Vivien Ripoll Merged in:
Authors: Travis Scrimshaw Reviewers:
Report Upstream: N/A Work issues:
Branch: public/combinat/root_systems/hyperbolic-15974 (Commits, GitHub, GitLab) Commit: be1375dc6fab554fd8a9e4db3aa2dab6a1264ad3
Dependencies: Stopgaps:

Status badges

Description (last modified by Travis Scrimshaw)

They are a important class of indeterminate Cartan types. They will be given in terms of the table given in Classification of hyperbolic Dynkin diagrams, root lengths, and Weyl group orbits by Carbone, Chung, Cobbs, McRae, Nandi, Naqvi, and Penta (http://arxiv.org/abs/1003.0564), as well as in some of the other notations specified in the aforementioned paper.

Change History (13)

comment:1 Changed 9 years ago by Travis Scrimshaw

Cc: Daniel Bump added
Description: modified (diff)

comment:2 Changed 8 years ago by Frédéric Chapoton

Keywords: coxeter added

comment:3 Changed 8 years ago by Travis Scrimshaw

Branch: public/combinat/root_systems/hyperbolic-15974
Commit: cd151340b52b7289169e0967b058eb708e5dcf0c

Current WIP version (I'm not guaranteeing anything to really work, nor for the structure to not change).


Last 10 new commits:

59c49b4Refactoring hyperbolic types and added Lorentzian types.
a920566More work on Lorentzian Cartan types.
ca06d90Moved type E Lorentzian to separate file, started rank 3 hyperbolic types.
9a07193More work on hyperbolic root systems.
d65fb76Merge branch 'develop' into public/combinat/root_systems/hyperbolic-15974
c655d51Implemented marked Cartan types and refactored common code.
80684beFixed last doctests and added to full coverage.
612db21Fixed last failing doctest.
964d8acMerge branch 'public/combinat/root_systems/marked_types-15948' into public/combinat/root_systems/hyperbolic-15974
cd15134Merge branch 'develop' into public/combinat/root_systems/hyperbolic-15974

comment:4 Changed 8 years ago by Travis Scrimshaw

Description: modified (diff)

comment:5 Changed 8 years ago by Jean-Philippe Labbé

Cc: Jean-Philippe Labbé added

comment:6 Changed 8 years ago by git

Commit: cd151340b52b7289169e0967b058eb708e5dcf0cae6d01cefde50ef11cc83f13324a2b3ee7d61f66

Branch pushed to git repo; I updated commit sha1. New commits:

ae6d01cMerge branch 'develop' into public/combinat/root_systems/hyperbolic-15974

comment:7 Changed 8 years ago by Nicolas M. Thiéry

Hi Travis!

Just a quick suggestion for less duplication in the code and a better isolation of the "database" part. Make:

if index == 1:
    dd = CartanType_Rank3Cycle._construct_dynkin_diagram((1,1,2))
elif index == 2:
    dd = CartanType_Rank3Cycle._construct_dynkin_diagram((1,1,-22))
elif index == 3:
   dd = CartanType_Rank3Cycle._construct_dynkin_diagram((1,1,3))
...

Into, at the start of the file and with a more specific name than data if possible:

    data = (None, (1,1,2), (1,1,-22), (1,1,3), ...)

And in the constructor:

    dd = CartanType_Rank3Cycle._construct_dynkin_diagram(data[i])

Cheers,

Nicolas

comment:8 Changed 8 years ago by For batch modifications

Milestone: sage-6.2sage-6.3

comment:9 Changed 8 years ago by git

Commit: ae6d01cefde50ef11cc83f13324a2b3ee7d61f66d170a5794b6e59185a9503c5dc03a23a26358e30

Branch pushed to git repo; I updated commit sha1. New commits:

a807b5fMerge branch 'public/combinat/root_systems/hyperbolic-15974' of trac.sagemath.org:sage into public/combinat/root_systems/hyperbolic-15974
8748c79Merge branch 'develop' into public/combinat/root_systems/hyperbolic-15974
d170a57Replaced Lorentzian with hyperbolic.

comment:10 Changed 8 years ago by For batch modifications

Milestone: sage-6.3sage-6.4

comment:11 Changed 8 years ago by Vivien Ripoll

Cc: Vivien Ripoll added

comment:12 Changed 8 years ago by git

Commit: d170a5794b6e59185a9503c5dc03a23a26358e30be1375dc6fab554fd8a9e4db3aa2dab6a1264ad3

Branch pushed to git repo; I updated commit sha1. New commits:

be1375dMerge branch 'public/combinat/root_systems/hyperbolic-15974' of trac.sagemath.org:sage into public/combinat/root_systems/hyperbolic-15974

comment:13 Changed 7 years ago by Frédéric Chapoton

Milestone: sage-6.4sage-6.8
Note: See TracTickets for help on using tickets.