Opened 6 years ago

Closed 6 years ago

#15967 closed defect (fixed)

Let bzip2 install shared libraries

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.2
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Jean-Pierre Flori Reviewers: Sebastien Gouezel
Report Upstream: N/A Work issues:
Branch: dc7dff9 (Commits) Commit: dc7dff92f9e0b83711168bba044284fc909da696
Dependencies: Stopgaps:

Description (last modified by jpflori)

This is an issue on Cygwin because libtool will complain when trying to link sahred libs to libbz2 which is only a (relocatable) archive right now.

Use tarball at:

Change History (20)

comment:1 Changed 6 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Status changed from new to needs_review

Solves the freetype issue from https://groups.google.com/d/msg/sage-devel/o5dm0qe8DPk/ps93J1iXFjYJ

Not tested on OS X.

comment:2 Changed 6 years ago by vbraun

The included Makefile-libbz2_so doesn't have a snowflake's chance in hell to work on OSX. Apply e.g. http://ftp.uni-kl.de/pub/linux/suse/people/sbrabec/bzip2/for_downstream/bzip2-1.0.6-autoconfiscated.patch

comment:3 Changed 6 years ago by jpflori

  • Branch set to u/jpflori/ticket/15967
  • Commit set to ff3222fa9e88d5df0bdd44ddb782bb1d60480ce6

Note that it should not be used. I tried to craft a minimally modified dylib Makefile. No idea if it has any chance to work. And I forgot to fill in the branch name so you may not have been aware of that...

Anyway I agree that autotoolizing might be a good idea. That's what MinGW and Cygwin do. It's just it was more complicated to setup, test quickly.


New commits:

ff3222fLet bzip2 build shared libraries.

comment:4 Changed 6 years ago by vbraun

What about solaris / sun linker?

comment:5 Changed 6 years ago by jpflori

Yeah, sure, I just tested and it fails, let's go the autotools way.

comment:6 Changed 6 years ago by jpflori

  • Status changed from needs_review to needs_work
  • Work issues set to autotools

comment:7 Changed 6 years ago by git

  • Commit changed from ff3222fa9e88d5df0bdd44ddb782bb1d60480ce6 to 457a4c3716bb9da267fd0e8f4e6aba324b10812e

Branch pushed to git repo; I updated commit sha1. New commits:

457a4c3Autotoolify bzip2 based on Suse patch.

comment:8 Changed 6 years ago by jpflori

  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Work issues autotools deleted

Looks ok on Linux. Will test back on Cygwin tomorrow.

comment:9 Changed 6 years ago by git

  • Commit changed from 457a4c3716bb9da267fd0e8f4e6aba324b10812e to dd7560c7445202a861a4c6bc5b5bf49d01482f3b

Branch pushed to git repo; I updated commit sha1. New commits:

dd7560cFix libdir for autotoolified bzip2.

comment:10 Changed 6 years ago by jhpalmieri

Works on OS X 10.8 and 10.9.

comment:11 Changed 6 years ago by jpflori

TO be completely clear on what was done, this branch use the aforementioned suse patch, with a few slight modifications:

  • update version numbers in configure.ac to 1.0.6 (there was a discrepancy in the file of the patch itself, surely introduced when the version was bumped from 1.0.5 to 1.0.6 or stg like that),
  • replace the libtool init macro AC_PROG_LIBTOOL by the correct one: LT_INIT with the win32-dll (I'm quite convincded the option does next to nothing but autotools doc says to add it).
  • do not include the autogen.sh file, anyway one should use the spkg-src instead and note that does slightly different things.

comment:12 Changed 6 years ago by gouezel

  • Status changed from needs_review to positive_review

Works for me on Cygwin (and compilation fails without the patch).

comment:13 Changed 6 years ago by vbraun

please fill in the reviewer name with your full name

comment:14 Changed 6 years ago by gouezel

  • Reviewers set to Sebastien Gouezel

comment:15 Changed 6 years ago by vbraun

  • Branch changed from u/jpflori/ticket/15967 to dd7560c7445202a861a4c6bc5b5bf49d01482f3b
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:16 Changed 6 years ago by jpflori

  • Commit dd7560c7445202a861a4c6bc5b5bf49d01482f3b deleted

Groumpf, I remarked yesterday evening that a "-a" would be welcome when copying the autotools stuff. Note though that it does not prevent the lib to get built...

comment:17 Changed 6 years ago by vbraun

  • Resolution fixed deleted
  • Status changed from closed to new

comment:18 Changed 6 years ago by jpflori

  • Branch changed from dd7560c7445202a861a4c6bc5b5bf49d01482f3b to u/jpflori/ticket/15967
  • Commit set to dc7dff92f9e0b83711168bba044284fc909da696
  • Status changed from new to needs_review

-a added


New commits:

ff3222fLet bzip2 build shared libraries.
457a4c3Autotoolify bzip2 based on Suse patch.
dd7560cFix libdir for autotoolified bzip2.
dc7dff9Pass "-a" to cp in bzip2 install script to copy subdirectories.

comment:19 Changed 6 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:20 Changed 6 years ago by vbraun

  • Branch changed from u/jpflori/ticket/15967 to dc7dff92f9e0b83711168bba044284fc909da696
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.