Opened 8 years ago

Closed 8 years ago

#15960 closed enhancement (fixed)

New function: FiniteStateMachine.set_coordinates

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.2
Component: combinatorics Keywords: finite_state_machine
Cc: dkrenn, skropf Merged in:
Authors: Clemens Heuberger, Daniel Krenn Reviewers: Clemens Heuberger, Daniel Krenn
Report Upstream: N/A Work issues:
Branch: f49c3ca (Commits, GitHub, GitLab) Commit: f49c3cafacdf70c2776ef0ae1e49c752acd663ce
Dependencies: Stopgaps:

Status badges

Description

Provide a new convenience function FiniteStateMachine.set_coordinates: Set coordinates of the states for the LaTeX representation by a dictionary (or a function) mapping labels to coordinates.

Change History (3)

comment:1 Changed 8 years ago by cheuberg

  • Cc skropf added
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by dkrenn

  • Reviewers set to Clemens Heuberger, Daniel Krenn
  • Status changed from needs_review to positive_review

During the review I made some changes in .set_coordinates, and also replaced a TODO by working code (allowing functions as argument). The changes were cross-reviewed by cheuberg.

Code looks fine; doctests pass, docu checked, coverage checked

Last edited 8 years ago by dkrenn (previous) (diff)

comment:3 Changed 8 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/set_coordinates to f49c3cafacdf70c2776ef0ae1e49c752acd663ce
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.