Opened 7 years ago
Closed 7 years ago
#15946 closed defect (fixed)
Cython warnings about mpz_t ("... referenced before assignment")
Reported by:  mmezzarobba  Owned by:  

Priority:  major  Milestone:  sage6.4 
Component:  cython  Keywords:  
Cc:  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  Volker Braun 
Report Upstream:  N/A  Work issues:  
Branch:  a52cff2 (Commits, GitHub, GitLab)  Commit:  a52cff291917bb738f781768be622de146905e0b 
Dependencies:  #16583, #16910  Stopgaps: 
Description (last modified by )
Similar to #16583, we should fix the declarations for mpz_t
(and related types). This also involves fixing:
 various bad usages of
mpz_t
(it wasctypedef
'ed asvoid*
, meaning you could do with it what you wanted and Cython wouldn't complain)  changing many functions to pass an
mpz_t
instead of anmpz_t*
. For example the NTL interface functionsmpz_to_ZZ
andZZ_to_mpz
and thepow_computer
functions from padics.
See also https://groups.google.com/forum/#!msg/sagedevel/bs4lnNwbINs/B2iVgxK7pCYJ
Change History (13)
comment:1 Changed 7 years ago by
 Type changed from PLEASE CHANGE to defect
comment:2 Changed 7 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:3 Changed 7 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:4 Changed 7 years ago by
 Dependencies set to #16583
comment:5 Changed 7 years ago by
 Dependencies changed from #16583 to #16583, #16910
comment:6 Changed 7 years ago by
 Component changed from basic arithmetic to cython
 Description modified (diff)
comment:7 Changed 7 years ago by
 Description modified (diff)
comment:8 Changed 7 years ago by
 Branch set to u/jdemeyer/ticket/15946
 Created changed from 03/15/14 15:03:15 to 03/15/14 15:03:15
 Modified changed from 08/30/14 21:17:33 to 08/30/14 21:17:33
comment:9 Changed 7 years ago by
 Status changed from new to needs_review
comment:10 Changed 7 years ago by
 Commit set to d76f8e7be8ad8f8a1a95b96e9413567f4389067e
 Description modified (diff)
comment:11 Changed 7 years ago by
 Commit changed from d76f8e7be8ad8f8a1a95b96e9413567f4389067e to a52cff291917bb738f781768be622de146905e0b
Branch pushed to git repo; I updated commit sha1. New commits:
a52cff2  Use mpz_srcptr for padics pow_computer

comment:12 Changed 7 years ago by
 Reviewers set to Volker Braun
 Status changed from needs_review to positive_review
comment:13 Changed 7 years ago by
 Branch changed from u/jdemeyer/ticket/15946 to a52cff291917bb738f781768be622de146905e0b
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
silence Cython warning about complicated declaration
merge
Merge with 6.4.beta1
trac #16583, oops, correcting wrong merge
Remove stuff which is not needed
Further cleanup
Fix include of fmpq_poly.pxi in Cython doctest
Get rid of mpz_t_offset hacks
Merge branch 'ticket/16910' into HEAD
Fix mpz_t, mpq_t, mpf_t declarations