#15938 closed enhancement (fixed)
Update NTL to 6.1.0
| Reported by: | jpflori | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-6.2 |
| Component: | packages: standard | Keywords: | |
| Cc: | vbraun | Merged in: | |
| Authors: | Jean-Pierre Flori | Reviewers: | François Bissey |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 85242fe (Commits, GitHub, GitLab) | Commit: | |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Just been released.
Use tarball (generated with spkg-src script) at:
Change History (14)
comment:1 Changed 9 years ago by
| Authors: | → Jean-Pierre Flori |
|---|---|
| Branch: | → u/jpflori/ticket/15938 |
| Cc: | vbraun added |
| Description: | modified (diff) |
comment:2 Changed 9 years ago by
| Commit: | → 6f0b76c18ba12ca25e74d5461d1f5c98edee786d |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| 6f0b76c | Update NTL to 6.1.0.
|
comment:3 Changed 9 years ago by
comment:4 follow-up: 7 Changed 9 years ago by
Ok, it seems it was just an old version of ntl so file lurking around.
comment:5 Changed 9 years ago by
| Commit: | 6f0b76c18ba12ca25e74d5461d1f5c98edee786d → 85242fee78aac04a81eaee27776fb6a6537ac1f0 |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| 85242fe | Make sure old NTL files are deleted.
|
comment:6 Changed 9 years ago by
| Status: | new → needs_review |
|---|
comment:7 Changed 9 years ago by
| Reviewers: | → François Bissey |
|---|---|
| Status: | needs_review → positive_review |
Replying to jpflori:
Ok, it seems it was just an old version of ntl so file lurking around.
So that was why I was scratching my head "but it works in sage-on-gentoo!". The rest looks all right to me and in use for a couple of weeks locally :) positive.
comment:9 Changed 9 years ago by
| Description: | modified (diff) |
|---|
comment:10 Changed 9 years ago by
| Branch: | u/jpflori/ticket/15938 → 85242fee78aac04a81eaee27776fb6a6537ac1f0 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
comment:11 Changed 9 years ago by
| Commit: | 85242fee78aac04a81eaee27776fb6a6537ac1f0 |
|---|
... Successfully installed ntl-6.1.0.p0 Running the test suite for ntl-6.1.0.p0... ./spkg-check: line 9: cd: src/src: No such file or directory Running NTL's test suite... make: *** No rule to make target `check'. Stop. NTL's test suite passed.
WHAT?
comment:13 Changed 9 years ago by
comment:14 Changed 9 years ago by
I am feeling very ashamed that both Jean-Pierre and I missed that. And it was working in 6.0 I am sure. I am fairly sure I ran it in 6.0 when it was included, I thought I ran it this time too and I am also fairly sure the test suite didn't really change that much between 6.0 and 6.1. One of these must be a figment of imagination.
Straightforward update.
Removed disable_help.patch (which did not apply anymore) as Victor fixed the issue (in a different way).
Not sure if it's because I did not recompiled everything correctly or eclib (interface?) does bad things, but I get a lot of complains/segfault about uninitialized ZZ_p modulus.