Opened 12 years ago

Closed 12 years ago

#1593 closed defect (fixed)

[with doc patch, with positive review] m4ri -- the documentation of the echelon command only lists 1 algorithm but >= 2 algorithms are supported

Reported by: was Owned by: malb
Priority: minor Milestone: sage-2.10.1
Component: documentation Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description


Attachments (1)

trac_1593.patch (1.3 KB) - added by malb 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by was

  • Owner changed from tba to malb

Also, there is a bug in algorithm = "classical", since it doesn't check for mutability and doesn't clear the cache.

Changed 12 years ago by malb

comment:2 Changed 12 years ago by malb

  • Status changed from new to assigned
  • Summary changed from m4ri -- the documentation of the echelon command only lists 1 algorithm but >= 2 algorithms are supported to [with doc patch] m4ri -- the documentation of the echelon command only lists 1 algorithm but >= 2 algorithms are supported

the attached patch adds 'classical' to the docstring of echelonize. The remark about algorithm="classical" is invalid because the called method _echelon_in_place_classical does check for mutability and clears the cache. See matrix2.pyx for details.

comment:3 Changed 12 years ago by mabshoff

  • Summary changed from [with doc patch] m4ri -- the documentation of the echelon command only lists 1 algorithm but >= 2 algorithms are supported to [with doc patch, needs review] m4ri -- the documentation of the echelon command only lists 1 algorithm but >= 2 algorithms are supported

comment:4 Changed 12 years ago by mabshoff

  • Summary changed from [with doc patch, needs review] m4ri -- the documentation of the echelon command only lists 1 algorithm but >= 2 algorithms are supported to [with doc patch, with positive review] m4ri -- the documentation of the echelon command only lists 1 algorithm but >= 2 algorithms are supported

Patch looks good to me.

Cheers,

Michael

comment:5 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 2.10.1.alpha2

Note: See TracTickets for help on using tickets.