Opened 8 years ago
Closed 7 years ago
#15914 closed enhancement (fixed)
Add the option to compute the fox derivative in a specific ring.
Reported by:  mmarco  Owned by:  

Priority:  major  Milestone:  sage6.4 
Component:  group theory  Keywords:  days57 
Cc:  jlopez, swenson, nborie, darij, vbraun, sydahmad, vdelecroix, jhpalmieri, tjolivet, rbeezer, dimpase, dshurbert  Merged in:  
Authors:  Miguel Marco  Reviewers:  Volker Braun, Darij Grinberg 
Report Upstream:  N/A  Work issues:  
Branch:  592fec3 (Commits, GitHub, GitLab)  Commit:  592fec397795e6e217f13b8ce598f06926f12a53 
Dependencies:  Stopgaps: 
Description
ADD DESCRIPTION Giving a list of the generators of the group in some algebra, the fox derivative can be computed in that algebra:
sage: F=FreeGroup(3) sage: a=F([2,1,3,1,2]) sage: a.fox_derivative(F([1])) B[x1]  B[x1*x0*x2*x0^1] sage: R.<t>=LaurentPolynomialRing(ZZ) sage: a.fox_derivative(F([1]),[t,t,t]) t^2 + t sage: S.<t1,t2,t3>=LaurentPolynomialRing(ZZ) sage: a.fox_derivative(F([1]),[t1,t2,t3]) t2*t3 + t2
Change History (27)
comment:1 Changed 8 years ago by
 Branch set to u/mmarco/ticket/15914
 Created changed from 03/09/14 19:28:56 to 03/09/14 19:28:56
 Modified changed from 03/09/14 19:28:56 to 03/09/14 19:28:56
comment:2 Changed 8 years ago by
 Cc jlopez swenson nborie darij vbraun sydahmad vdelecroix jhpalmieri tjolivet rbeezer dimpase dshurbert added
 Commit set to 00d6961d9785fe6d1e66a6a44f48e6df729ee07e
 Status changed from new to needs_review
comment:3 Changed 8 years ago by
 Commit changed from 00d6961d9785fe6d1e66a6a44f48e6df729ee07e to af6a39390700947154d4cc2b97b68ccf88ecab19
Branch pushed to git repo; I updated commit sha1. New commits:
af6a393  Added the option to give im_gens also in alexander matrix.

comment:4 Changed 8 years ago by
In fact i don't like much the documentation, but i couldn't come out with something better. So, any suggestions?
comment:5 Changed 8 years ago by
 Reviewers set to Volker Braun
Can you use the standard docstring markup (http://www.sagemath.org/doc/developer/coding_basics.html#docstringmarkupwithrestandsphinx) for the INPUT sections? Also, whitespace in the EXAMPLES should follow the usual code style. Apart from that looks fine.
comment:6 Changed 8 years ago by
 Keywords days57 added
comment:7 Changed 8 years ago by
 Commit changed from af6a39390700947154d4cc2b97b68ccf88ecab19 to c5fcf9877f242e29baa9effd9f108701bd3c3453
Branch pushed to git repo; I updated commit sha1. New commits:
c5fcf98  Correction of documentation

comment:8 Changed 8 years ago by
Improved documentation style.
comment:9 Changed 8 years ago by
 Commit changed from c5fcf9877f242e29baa9effd9f108701bd3c3453 to 7d0e8143ca3825260ef19c72cece95e79fd46bbf
Branch pushed to git repo; I updated commit sha1. New commits:
7d0e814  Correct mesh with graph editor

comment:10 Changed 8 years ago by
Sorry, i messed with the graph editor, this should fix it.
New commits:
7d0e814  Correct mesh with graph editor

comment:11 Changed 8 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:12 Changed 8 years ago by
 Status changed from needs_review to needs_work
Please always check if the documentation builds.
OSError: [groups ] /home/pbruin/src/sagepatchbot/sage/local/lib/python2.7/sitepackages/ sage/groups/finitely_presented.py:docstring of sage.groups.finitely_presented:6: WARNING: Bullet list ends without a blank line; unexpected unindent. make: *** [dochtml] Error 1
comment:13 Changed 8 years ago by
 Commit changed from 7d0e8143ca3825260ef19c72cece95e79fd46bbf to 175510a2f55288fded3e51248c2bee8810d2a871
Branch pushed to git repo; I updated commit sha1. New commits:
cb1d62e  Added the option to give the images of the generators, and hence define theresult in a different algebra.

d750efc  Added the option to give im_gens also in alexander matrix.

d712122  Correction of documentation

829960b  Correct mesh with graph editor

99ef404  Rebased to version 6.2, fixed documentation.

879ddd0  Merge branch 'u/mmarco/ticket/15914' of git://trac.sagemath.org/sage into ticket/15914

175510a  Solved issue with documentation

comment:14 Changed 8 years ago by
 Status changed from needs_work to needs_review
comment:15 Changed 7 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:16 Changed 7 years ago by
 Branch changed from u/mmarco/ticket/15914 to public/15914
 Commit changed from 175510a2f55288fded3e51248c2bee8810d2a871 to 6ef5e5b46c49f9b056c3bc2fcce114441a16021a
comment:17 Changed 7 years ago by
I've uploaded a review patch. If you are fine with my changes, please set this ticket to positive_review.
comment:18 Changed 7 years ago by
your last commit doesn't pass the doctests. Mainly because F([])
is not a generator of the free group. Also tuple((0 for _ in self.ngens()))
fails, since you cannot iterate over a number.
comment:19 Changed 7 years ago by
Yeah, I somehow uploaded an unfinished version. Let me fix this quickly.
comment:20 Changed 7 years ago by
 Commit changed from 6ef5e5b46c49f9b056c3bc2fcce114441a16021a to b0833ad39d6019c8d1523beafafc1850dc96aea6
Branch pushed to git repo; I updated commit sha1. New commits:
b0833ad  finishing the patch

comment:21 Changed 7 years ago by
Corrected method and tests. Thanks for noticing!
comment:22 Changed 7 years ago by
 Status changed from needs_review to positive_review
Looks good. Please add your full name to the reviewer's list.
comment:23 Changed 7 years ago by
 Reviewers changed from Volker Braun to Volker Braun, Darij Grinberg
comment:24 Changed 7 years ago by
 Status changed from positive_review to needs_work
PDF docs don't build
comment:25 Changed 7 years ago by
 Commit changed from b0833ad39d6019c8d1523beafafc1850dc96aea6 to 592fec397795e6e217f13b8ce598f06926f12a53
Branch pushed to git repo; I updated commit sha1. New commits:
592fec3  latex fixed

comment:26 Changed 7 years ago by
 Status changed from needs_work to positive_review
Thank you  found and fixed.
comment:27 Changed 7 years ago by
 Branch changed from public/15914 to 592fec397795e6e217f13b8ce598f06926f12a53
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Added the option to give the images of the generators, and hence define theresult in a different algebra.