Opened 8 years ago

Closed 7 years ago

#15914 closed enhancement (fixed)

Add the option to compute the fox derivative in a specific ring.

Reported by: mmarco Owned by:
Priority: major Milestone: sage-6.4
Component: group theory Keywords: days57
Cc: jlopez, swenson, nborie, darij, vbraun, sydahmad, vdelecroix, jhpalmieri, tjolivet, rbeezer, dimpase, dshurbert Merged in:
Authors: Miguel Marco Reviewers: Volker Braun, Darij Grinberg
Report Upstream: N/A Work issues:
Branch: 592fec3 (Commits, GitHub, GitLab) Commit: 592fec397795e6e217f13b8ce598f06926f12a53
Dependencies: Stopgaps:

Status badges

Description

ADD DESCRIPTION Giving a list of the generators of the group in some algebra, the fox derivative can be computed in that algebra:

sage: F=FreeGroup(3)
sage: a=F([2,1,3,-1,2])
sage: a.fox_derivative(F([1]))
B[x1] - B[x1*x0*x2*x0^-1]
sage: R.<t>=LaurentPolynomialRing(ZZ)
sage: a.fox_derivative(F([1]),[t,t,t])
-t^2 + t
sage: S.<t1,t2,t3>=LaurentPolynomialRing(ZZ)
sage: a.fox_derivative(F([1]),[t1,t2,t3])
-t2*t3 + t2

Change History (27)

comment:1 Changed 8 years ago by mmarco

  • Branch set to u/mmarco/ticket/15914
  • Created changed from 03/09/14 19:28:56 to 03/09/14 19:28:56
  • Modified changed from 03/09/14 19:28:56 to 03/09/14 19:28:56

comment:2 Changed 8 years ago by mmarco

  • Cc jlopez swenson nborie darij vbraun sydahmad vdelecroix jhpalmieri tjolivet rbeezer dimpase dshurbert added
  • Commit set to 00d6961d9785fe6d1e66a6a44f48e6df729ee07e
  • Status changed from new to needs_review

New commits:

00d6961Added the option to give the images of the generators, and hence define theresult in a different algebra.

comment:3 Changed 8 years ago by git

  • Commit changed from 00d6961d9785fe6d1e66a6a44f48e6df729ee07e to af6a39390700947154d4cc2b97b68ccf88ecab19

Branch pushed to git repo; I updated commit sha1. New commits:

af6a393Added the option to give im_gens also in alexander matrix.

comment:4 Changed 8 years ago by mmarco

In fact i don't like much the documentation, but i couldn't come out with something better. So, any suggestions?

comment:5 Changed 8 years ago by vbraun

  • Authors set to Miguel Marco
  • Reviewers set to Volker Braun

Can you use the standard docstring markup (http://www.sagemath.org/doc/developer/coding_basics.html#docstring-markup-with-rest-and-sphinx) for the INPUT sections? Also, whitespace in the EXAMPLES should follow the usual code style. Apart from that looks fine.

comment:6 Changed 8 years ago by vbraun

  • Keywords days57 added

comment:7 Changed 8 years ago by git

  • Commit changed from af6a39390700947154d4cc2b97b68ccf88ecab19 to c5fcf9877f242e29baa9effd9f108701bd3c3453

Branch pushed to git repo; I updated commit sha1. New commits:

c5fcf98Correction of documentation

comment:8 Changed 8 years ago by mmarco

Improved documentation style.

comment:9 Changed 8 years ago by git

  • Commit changed from c5fcf9877f242e29baa9effd9f108701bd3c3453 to 7d0e8143ca3825260ef19c72cece95e79fd46bbf

Branch pushed to git repo; I updated commit sha1. New commits:

7d0e814Correct mesh with graph editor

comment:10 Changed 8 years ago by mmarco

Sorry, i messed with the graph editor, this should fix it.


New commits:

7d0e814Correct mesh with graph editor

comment:11 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:12 Changed 8 years ago by rws

  • Status changed from needs_review to needs_work

Please always check if the documentation builds.

OSError: [groups   ] /home/pbruin/src/sage-patchbot/sage/local/lib/python2.7/site-packages/
sage/groups/finitely_presented.py:docstring of sage.groups.finitely_presented:6:
WARNING: Bullet list ends without a blank line; unexpected unindent.

make: *** [doc-html] Error 1

comment:13 Changed 8 years ago by git

  • Commit changed from 7d0e8143ca3825260ef19c72cece95e79fd46bbf to 175510a2f55288fded3e51248c2bee8810d2a871

Branch pushed to git repo; I updated commit sha1. New commits:

cb1d62eAdded the option to give the images of the generators, and hence define theresult in a different algebra.
d750efcAdded the option to give im_gens also in alexander matrix.
d712122Correction of documentation
829960bCorrect mesh with graph editor
99ef404Rebased to version 6.2, fixed documentation.
879ddd0Merge branch 'u/mmarco/ticket/15914' of git://trac.sagemath.org/sage into ticket/15914
175510aSolved issue with documentation

comment:14 Changed 8 years ago by mmarco

  • Status changed from needs_work to needs_review

comment:15 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:16 Changed 7 years ago by darij

  • Branch changed from u/mmarco/ticket/15914 to public/15914
  • Commit changed from 175510a2f55288fded3e51248c2bee8810d2a871 to 6ef5e5b46c49f9b056c3bc2fcce114441a16021a

New commits:

7cfcad8Merge branch 'u/mmarco/ticket/15914' of git://trac.sagemath.org/sage into fox
6ef5e5breview patch for extended Fox derivative

comment:17 Changed 7 years ago by darij

I've uploaded a review patch. If you are fine with my changes, please set this ticket to positive_review.

comment:18 Changed 7 years ago by mmarco

your last commit doesn't pass the doctests. Mainly because F([]) is not a generator of the free group. Also tuple((0 for _ in self.ngens())) fails, since you cannot iterate over a number.

comment:19 Changed 7 years ago by darij

Yeah, I somehow uploaded an unfinished version. Let me fix this quickly.

comment:20 Changed 7 years ago by git

  • Commit changed from 6ef5e5b46c49f9b056c3bc2fcce114441a16021a to b0833ad39d6019c8d1523beafafc1850dc96aea6

Branch pushed to git repo; I updated commit sha1. New commits:

b0833adfinishing the patch

comment:21 Changed 7 years ago by darij

Corrected method and tests. Thanks for noticing!

comment:22 Changed 7 years ago by mmarco

  • Status changed from needs_review to positive_review

Looks good. Please add your full name to the reviewer's list.

comment:23 Changed 7 years ago by darij

  • Reviewers changed from Volker Braun to Volker Braun, Darij Grinberg

comment:24 Changed 7 years ago by vbraun

  • Status changed from positive_review to needs_work

PDF docs don't build

comment:25 Changed 7 years ago by git

  • Commit changed from b0833ad39d6019c8d1523beafafc1850dc96aea6 to 592fec397795e6e217f13b8ce598f06926f12a53

Branch pushed to git repo; I updated commit sha1. New commits:

592fec3latex fixed

comment:26 Changed 7 years ago by darij

  • Status changed from needs_work to positive_review

Thank you -- found and fixed.

comment:27 Changed 7 years ago by vbraun

  • Branch changed from public/15914 to 592fec397795e6e217f13b8ce598f06926f12a53
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.