Opened 8 years ago

Closed 8 years ago

#15907 closed enhancement (fixed)

Improvements for affine factorization crystal

Reported by: aschilling Owned by:
Priority: major Milestone: sage-6.2
Component: combinatorics Keywords: crystals, Stanley symmetric functions, reduced words
Cc: sage-combinat, tscrim Merged in:
Authors: Anne Schilling Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 45b6e9d (Commits, GitHub, GitLab) Commit: 45b6e9deac4a3eb1f67bde96e01d0ff04045face
Dependencies: Stopgaps:

Status badges

Description (last modified by aschilling)

This patch provides some improvements for the affine factorization crystal. Before this patch

sage: from sage.combinat.crystals.affine_factorization import AffineFactorizationCrystal
sage: W = WeylGroup(['A',3], prefix='s')
sage: w0 = W.long_element()
sage: %timeit B = AffineFactorizationCrystal(w0,6)
1 loops, best of 3: 131 s per loop

After this patch

sage: from sage.combinat.crystals.affine_factorization import AffineFactorizationCrystal
sage: W = WeylGroup(['A',3], prefix='s')
sage: w0 = W.long_element()
sage: %timeit B = AffineFactorizationCrystal(w0,6)
1 loops, best of 3: 2.86 us per loop

Change History (8)

comment:1 Changed 8 years ago by aschilling

  • Cc tscrim added
  • Description modified (diff)

comment:2 Changed 8 years ago by aschilling

  • Branch set to u/aschilling/15907/affine_factorization_crystal
  • Commit set to ec831523b7e062968ed7e6c2eca12b58f52b7a5d
  • Status changed from new to needs_review

New commits:

ec83152Changed generators in affine_factorization crystal to speed it up

comment:3 Changed 8 years ago by git

  • Commit changed from ec831523b7e062968ed7e6c2eca12b58f52b7a5d to 402f874d643f2802ec81cbdd173aba3190729c8a

Branch pushed to git repo; I updated commit sha1. New commits:

402f874removed k from init

comment:4 Changed 8 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Looks good. Thanks Anne.

comment:5 follow-up: Changed 8 years ago by git

  • Commit changed from 402f874d643f2802ec81cbdd173aba3190729c8a to 45b6e9deac4a3eb1f67bde96e01d0ff04045face
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

45b6e9dMerge branch 'develop' into u/aschilling/15907/affine_factorization_crystal

comment:6 in reply to: ↑ 5 Changed 8 years ago by aschilling

Merged in most recent development branch.

comment:7 Changed 8 years ago by aschilling

  • Status changed from needs_review to positive_review

comment:8 Changed 8 years ago by vbraun

  • Branch changed from u/aschilling/15907/affine_factorization_crystal to 45b6e9deac4a3eb1f67bde96e01d0ff04045face
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.