Opened 7 years ago

Closed 7 years ago

#15896 closed defect (fixed)

integration of polynomials in several variables is buggy

Reported by: chapoton Owned by:
Priority: major Milestone: sage-6.3
Component: commutative algebra Keywords: integration of polynomials, bug
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: ad17470 (Commits) Commit: ad17470cd32a87e8e61b4aad2583fb94644b49e0
Dependencies: Stopgaps:

Description

Here is the problem: 

sage: x,y=polygen(QQ,'x,y')
sage: x.integral(x)
1/2*x^2
sage: x.integral(x).parent()
Multivariate Polynomial Ring in x, y over Rational Field
sage: x.integral(x)+y
BOOM

Change History (8)

comment:1 Changed 7 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch set to u/chapoton/15896
  • Commit set to ad17470cd32a87e8e61b4aad2583fb94644b49e0

Here is the solution, please review.

New commits:

​ad17470trac #15896 much better code

comment:2 Changed 7 years ago by chapoton

  • Status changed from new to needs_review

comment:3 Changed 7 years ago by mmezzarobba

A more specific commit message would not be unwelcome :-)

comment:4 Changed 7 years ago by chapoton

Euh, well, bon, ok.

I have changed my own bad code (which was mixing different sorts of multivariate polynomials) to something with more cython, which is staying in the singular multivariate polynomials.

comment:5 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:6 Changed 7 years ago by chapoton

  • Keywords bug added

This is an important bug, in my humble opinion. Could someone please have a look ?

comment:7 Changed 7 years ago by pbruin

  • Reviewers set to Peter Bruin
  • Status changed from needs_review to positive_review

Looks good (to the Singular-untrained eye, admittedly) and the patchbot is happy.

comment:8 Changed 7 years ago by vbraun

  • Branch changed from u/chapoton/15896 to ad17470cd32a87e8e61b4aad2583fb94644b49e0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.