Opened 5 years ago
Closed 5 years ago
#15895 closed defect (fixed)
Bug in Graph.subdivide_edge
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.2 
Component:  graph theory  Keywords:  
Cc:  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  0d8480d (Commits)  Commit:  0d8480dd91233fb3a64242177ba54237dfffed65 
Dependencies:  Stopgaps: 
Description
As reported by Georgi Guninski:
sage: F=graphs.PathGraph(3); sage: S='S';F.add_vertex(S); sage: F.add_edges([(S,0)]); sage: F2=Graph(F); sage: F2.subdivide_edges(list(F2.edges(labels=False)),2); sage: F2.degree() [2, 2, 1, 0, 2, 0, 2, 0, 2, 5]
after relabel:
sage: F=graphs.PathGraph(3); sage: S='S'; sage: F.add_vertex(S); sage: F.add_edges([(S,0)]); sage: F2=Graph(F); sage: F2.relabel(); sage: F2.subdivide_edges(list(F2.edges(labels=False)),2); sage: F2.degree() [2, 2, 1, 1, 2, 2, 2, 2, 2, 2]
This bug, as very often, happened because I am an idiot.
Nathann
Change History (5)
comment:1 Changed 5 years ago by
 Branch set to u/ncohen/15895
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
 Commit set to b27adaac3f98745fe99839d493324ebd32b9cec2
comment:3 Changed 5 years ago by
 Branch changed from u/ncohen/15895 to public/ticket/15895
 Commit changed from b27adaac3f98745fe99839d493324ebd32b9cec2 to 0d8480dd91233fb3a64242177ba54237dfffed65
Looks good to me. I have made a cosmetic review patch. If you agree with my changes, you can set to positive review.
New commits:
0d8480d  trac #15895 review patch

comment:4 Changed 5 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
Okayyyy, then it is good to go ! Thanks :)
Nathann
comment:5 Changed 5 years ago by
 Branch changed from public/ticket/15895 to 0d8480dd91233fb3a64242177ba54237dfffed65
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
trac #15895: Bug in Graph.subdivide_edge