Opened 7 years ago
Closed 7 years ago
#15894 closed enhancement (fixed)
proper names should start with a capital letter
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.2 |
Component: | misc | Keywords: | typography |
Cc: | sage-combinat | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | André Apitzsch |
Report Upstream: | N/A | Work issues: | |
Branch: | 8c9c684 (Commits) | Commit: | 8c9c684255f01f871c222fb06f6a6421b3e11432 |
Dependencies: | Stopgaps: |
Description (last modified by )
One should look for instances of coxeter, dynkin, weyl, weil, bruhat, cartan, borel, galois that should be written with a capital letter.
Change History (8)
comment:1 Changed 7 years ago by
- Branch set to u/chapoton/15894
- Cc sage-combinat added
- Commit set to 4f8ada826843c998a73676339c86528d50889273
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
- Status changed from needs_review to needs_work
comment:3 Changed 7 years ago by
- Commit changed from 4f8ada826843c998a73676339c86528d50889273 to 80e8727bb747d6682a58c978c84587897f074440
comment:4 Changed 7 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
I have removed the changes affecting the categories, as this was causing failing doctests. The branch should now be ready for review.
comment:5 Changed 7 years ago by
Looks good, but could you also change the remaining
warning::
to
.. warning::
in src/sage/combinat/root_system/root_lattice_realizations.py
.
comment:6 Changed 7 years ago by
- Commit changed from 80e8727bb747d6682a58c978c84587897f074440 to 8c9c684255f01f871c222fb06f6a6421b3e11432
Branch pushed to git repo; I updated commit sha1. New commits:
8c9c684 | trac #15894 modif of two warnings
|
comment:7 Changed 7 years ago by
- Reviewers set to André Apitzsch
- Status changed from needs_review to positive_review
comment:8 Changed 7 years ago by
- Branch changed from u/chapoton/15894 to 8c9c684255f01f871c222fb06f6a6421b3e11432
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
trac #15xxx proper names should start by a capital letter