Opened 5 years ago
Closed 5 years ago
#15893 closed enhancement (fixed)
The Petersen Family
| Reported by: | ncohen | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-6.2 |
| Component: | graph theory | Keywords: | |
| Cc: | tmonteil | Merged in: | |
| Authors: | Nathann Cohen | Reviewers: | Frédéric Chapoton |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 5a75528 (Commits) | Commit: | 5a7552819f837de5f145a2a9abc5489338ff6061 |
| Dependencies: | Stopgaps: |
Description
Change History (6)
comment:1 Changed 5 years ago by
- Branch set to u/ncohen/15893
- Status changed from new to needs_review
comment:2 Changed 5 years ago by
- Commit set to bbec91585c739b010287f932b45dfe85ee84a266
comment:3 Changed 5 years ago by
- Branch changed from u/ncohen/15893 to u/chapoton/15893
- Commit changed from bbec91585c739b010287f932b45dfe85ee84a266 to 5a7552819f837de5f145a2a9abc5489338ff6061
Hello,
here is a review patch.
It looks good to me and you can set to positive review if you want.
One suggestion : maybe Y-Delta and Delta-Y transformations can be useful to have as general methods ? in another ticket ?
New commits:
| 5a75528 | trac #15893 review patch
|
comment:4 Changed 5 years ago by
Good for me ! Thank you very much :-)
About making those functions public: I only thought they were too specific to be Graph functions... It's not a huge loss even if somebody rewrites them for they are very easy and short, and well... The graph library already contains more useful stuff which is only available in modules, sooooo... :-)
Nathann
comment:5 Changed 5 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
by the way, can you name your branch public/something when you modify somebody else's branch ? This way if I have things to change later we don't keep changing the branch name and we can work on the same.
Nathann
comment:6 Changed 5 years ago by
- Branch changed from u/chapoton/15893 to 5a7552819f837de5f145a2a9abc5489338ff6061
- Resolution set to fixed
- Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
trac #15893: graphs.petersen_family