Change History (29)

comment:1 Changed 6 years ago by vbraun

  • Authors set to Volker Braun
  • Component changed from PLEASE CHANGE to packages: standard
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 6 years ago by vbraun

  • Description modified (diff)

comment:3 Changed 6 years ago by vbraun

This includes the sparc fix, for the record.

comment:4 Changed 6 years ago by vbraun

  • Branch set to u/vbraun/update_gap_4_7_4

comment:5 Changed 6 years ago by vbraun

  • Commit set to f17605b514e9a545f9aa789f69a9b36c4b53465a
  • Status changed from new to needs_review

Last 10 new commits:

9bb3e1aadd atlasrep to database_gap (dependency for tomlib)
b895477fix doctests: different gap generator orders
3bb8bdbalso fix long doctests
65342e6Merge branch 'public/groups/fp_groups-15145' into public/ticket/15582
05220a8Merge remote-tracking branch 'trac/develop' into t/15582/public/ticket/15582
a147b7fremove duplicated changelog
f802168add SPARC alignment fix
a41153fapply sparc patch also to libgap
1dc5d9efix trivial doctest failure
f17605budpate to GAP-4.7.4

comment:6 Changed 6 years ago by jpflori

  • Cc jpflori added

comment:7 follow-up: Changed 6 years ago by jpflori

What's the reason behind changing the example in src/doc/en/thematic_tutorials/group_theory.rst to a smaller example? Was it too slow?

comment:8 Changed 6 years ago by dimpase

  • Cc dimpase added

comment:9 Changed 6 years ago by dimpase

I can't find in the docs the way to review such kind of tickets in the git way. What should be done besides

sage -dev checkout --ticket 15873
sage -b

Thanks!

comment:10 follow-up: Changed 6 years ago by jpflori

I don't really know. Have a look at the changes? You can click on the branch name here or use git diff with something like:

git diff trac/develop

comment:11 in reply to: ↑ 10 Changed 6 years ago by dimpase

Replying to jpflori:

I don't really know. Have a look at the changes?

no, I mean, what to do with the tarballs? I sort of know what to do with tickets without tarballs...

comment:12 Changed 6 years ago by jpflori

Ah, sure. Just download them to the upstream directory and then do what you suggested to rebuild Sage.

comment:13 follow-up: Changed 6 years ago by jpflori

FYI, it compiled and build doc without trouble on a sparc/solaris machine I have access to. Otherwise the changes look ok to me. I'll just check I can build it on another machine and give it a quick look there and I'll be happy with the update when Volker answer my previous question from comment:7.

comment:14 in reply to: ↑ 13 Changed 6 years ago by tscrim

Replying to jpflori:

FYI, it compiled and build doc without trouble on a sparc/solaris machine I have access to. Otherwise the changes look ok to me. I'll just check I can build it on another machine and give it a quick look there and I'll be happy with the update when Volker answer my previous question from comment:7.

See #15582 comment 10.

comment:15 Changed 6 years ago by jpflori

It seems the atlasrep pkg is not installed by database_gap. Adding this to spkg-install makes more doctests depending on atlasrep or tomlib happy.

comment:16 in reply to: ↑ 7 Changed 6 years ago by vbraun

Replying to jpflori:

What's the reason behind changing the example in src/doc/en/thematic_tutorials/group_theory.rst to a smaller example? Was it too slow?

See #15582 comment 10

EDIT: I see Travis was faster ;-)

Last edited 6 years ago by vbraun (previous) (diff)

comment:17 Changed 6 years ago by git

  • Commit changed from f17605b514e9a545f9aa789f69a9b36c4b53465a to 50a4b403e07f96259f4b122566c76f1512f8742a

Branch pushed to git repo; I updated commit sha1. New commits:

50a4b40also install AtlasRep from the database_gap tarball

comment:18 Changed 6 years ago by jpflori

Ok everything seems fine to me for this upgrade to get merged. Maybe an additional commit to remove the history from newly gitified pkgs?

comment:19 Changed 6 years ago by vbraun

Feel free to do that if you feel strongly about it.

comment:20 Changed 6 years ago by jpflori

  • Branch changed from u/vbraun/update_gap_4_7_4 to u/jpflori/ticket/15873
  • Commit changed from 50a4b403e07f96259f4b122566c76f1512f8742a to 1a91835f99e01395b74226e185ed88f6cf26031a
  • Reviewers set to Jean-Pierre Flori
  • Status changed from needs_review to positive_review

Not so strongly, but that was easy enough to modify and don't think it needs to get rereviewed, so here are the changes and let's merge this one.

I also very slightly reformatted the patch part of SPKG.txt to look more like other pkgs.


New commits:

1a91835Slight modifications of gap related pkgs SPKG.txt files.

comment:21 Changed 6 years ago by vbraun

  • Branch changed from u/jpflori/ticket/15873 to 1a91835f99e01395b74226e185ed88f6cf26031a
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:22 Changed 6 years ago by mmarco

  • Commit 1a91835f99e01395b74226e185ed88f6cf26031a deleted

If i try to checkout, i get the following:

mmarco@artin:~/sage/sage$ ./sage -dev checkout --ticket 15873
The branch field on ticket #15873 is set to the non-existent "1a91835f99e01395b74226e185ed88f6cf26031a". Please set the field on trac to a field value.                                                            
                                                                                                                                                                                                                   
#  (use "sage --dev edit-ticket --ticket=15873" to edit the ticket description)      

comment:23 Changed 6 years ago by vbraun

Thats a bug in the sage dev scripts, apparently they can't handle SHA1 directly.

comment:24 Changed 6 years ago by mmarco

So, is there a solution?

comment:25 Changed 6 years ago by vbraun

I've released 6.2.beta3 which includes this ticket, so you can just checkout that version. Alternatively, don't use the dev scripts (I don't use them).

comment:26 Changed 6 years ago by dimpase

Remove binary junk in gap_packages-4.7.4.tar.bz2! There is stuff in src/grape/bin/i686-pc-cygwin-gcc-default32/

comment:27 Changed 6 years ago by dimpase

In guava's PackageInfo.g one has

  Autoload := false,

This apparently causes the issue in #15908. One possible fix for the latter would be to change to

  Autoload := true,

comment:28 Changed 6 years ago by dimpase

Dear reviewers of optional package updates: please run the appropriate tests before giving OK...

comment:29 Changed 6 years ago by vbraun

This ticket is closed FYI...

Note: See TracTickets for help on using tickets.