Opened 8 years ago

Closed 8 years ago

#15849 closed enhancement (fixed)

Default ordering of States and Transitions in FiniteStateMachine

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.2
Component: combinatorics Keywords: finite_state_machine
Cc: Merged in:
Authors: Clemens Heuberger, Daniel Krenn Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 9af0b91 (Commits, GitHub, GitLab) Commit: 9af0b91992bf0ff267a2c8c684b1f79b456f4a1e
Dependencies: Stopgaps:

Status badges

Description (last modified by cheuberg)

Provided methods sage.combinat.finite_state_machine.FSMState.__lt__ and sage.combinat.finite_state_machine.FSMTransition.__lt__ in order to have default ordering. For instance, this helps enforcing a unique output in doctests.

Change History (6)

comment:1 Changed 8 years ago by cheuberg

  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 8 years ago by cheuberg

  • Authors changed from Clemens Heuberger to Clemens Heuberger, Daniel Krenn
  • Branch set to u/cheuberg/fsm/default-order-states-transitions
  • Cc dkrenn added
  • Commit set to 9af0b91992bf0ff267a2c8c684b1f79b456f4a1e
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​a232e7cimplemented FSMTransition.__lt__ and FSMState.__lt__
​345c184rewrote docstring of .__lt__ in FSMState/FSMTransition; corrected spacings
​fa01ea3added one spaceing (PEP8)
​9af0b91Whitespace correction in FSMTransition.__lt__

comment:3 Changed 8 years ago by dkrenn

  • Cc dkrenn removed
  • Reviewers set to Daniel Krenn

comment:4 Changed 8 years ago by dkrenn

  • Status changed from needs_review to positive_review

comment:5 Changed 8 years ago by dkrenn

Corrected spacings (PEP8)

code looks fine, doctests pass, docu checked, coverage checked

comment:6 Changed 8 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/default-order-states-transitions to 9af0b91992bf0ff267a2c8c684b1f79b456f4a1e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.