Opened 8 years ago
Closed 8 years ago
#15847 closed enhancement (fixed)
Do deepcopy + reset label in FiniteStateMachine.quotient instead of creating a new state
Reported by: | cheuberg | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.2 |
Component: | combinatorics | Keywords: | finite_state_machine |
Cc: | Merged in: | ||
Authors: | Clemens Heuberger, Daniel Krenn | Reviewers: | Daniel Krenn |
Report Upstream: | N/A | Work issues: | |
Branch: | c518d08 (Commits, GitHub, GitLab) | Commit: | c518d0808336d148454d290c41ffefc3d5467bac |
Dependencies: | Stopgaps: |
Description (last modified by )
In
sage.combinat.finite_state_machine.FiniteStateMachine.quotient
,
do not create a new state, but make deepcopy + reset label in order to
preserve possible additional information of the state.
Change History (5)
comment:1 Changed 8 years ago by
- Branch set to u/cheuberg/fsm/quotient-deepcopy-state
- Cc dkrenn added
- Commit set to c518d0808336d148454d290c41ffefc3d5467bac
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Cc dkrenn removed
- Reviewers set to Daniel Krenn
comment:3 Changed 8 years ago by
- Status changed from needs_review to positive_review
comment:4 Changed 8 years ago by
code looks fine, doctests pass, docu checked, coverage checked
comment:5 Changed 8 years ago by
- Branch changed from u/cheuberg/fsm/quotient-deepcopy-state to c518d0808336d148454d290c41ffefc3d5467bac
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
deepcopy + reset label in FiniteStateMachine.quotient
Removed Whitespace according PEP 8
corrected spacings (PEP8); added line-breaks in long lines
using relabeled instead of deepcopy (former TODO)