Opened 9 years ago

Closed 9 years ago

#15847 closed enhancement (fixed)

Do deepcopy + reset label in FiniteStateMachine.quotient instead of creating a new state

Reported by: Clemens Heuberger Owned by:
Priority: minor Milestone: sage-6.2
Component: combinatorics Keywords: finite_state_machine
Cc: Merged in:
Authors: Clemens Heuberger, Daniel Krenn Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: c518d08 (Commits, GitHub, GitLab) Commit: c518d0808336d148454d290c41ffefc3d5467bac
Dependencies: Stopgaps:

Status badges

Description (last modified by Clemens Heuberger)

In sage.combinat.finite_state_machine.FiniteStateMachine.quotient, do not create a new state, but make deepcopy + reset label in order to preserve possible additional information of the state.

Change History (5)

comment:1 Changed 9 years ago by Clemens Heuberger

Authors: Clemens Heuberger → Clemens Heuberger, Daniel Krenn
Branch: → u/cheuberg/fsm/quotient-deepcopy-state
Cc: Daniel Krenn added
Commit: → c518d0808336d148454d290c41ffefc3d5467bac
Description: modified (diff)
Status: new → needs_review

New commits:

​1bc867fdeepcopy + reset label in FiniteStateMachine.quotient
​33442a3Removed Whitespace according PEP 8
​709d3a4corrected spacings (PEP8); added line-breaks in long lines
​c518d08using relabeled instead of deepcopy (former TODO)

comment:2 Changed 9 years ago by Daniel Krenn

Cc: Daniel Krenn removed
Reviewers: → Daniel Krenn

comment:3 Changed 9 years ago by Daniel Krenn

Status: needs_review → positive_review

comment:4 Changed 9 years ago by Daniel Krenn

code looks fine, doctests pass, docu checked, coverage checked

comment:5 Changed 9 years ago by Volker Braun

Branch: u/cheuberg/fsm/quotient-deepcopy-state → c518d0808336d148454d290c41ffefc3d5467bac
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.