Opened 8 years ago
Closed 8 years ago
#15840 closed enhancement (fixed)
Residues in SymbolicRing
Reported by:  dkrenn  Owned by:  

Priority:  major  Milestone:  sage6.2 
Component:  symbolics  Keywords:  
Cc:  Merged in:  
Authors:  Daniel Krenn  Reviewers:  Marc Mezzarobba 
Report Upstream:  N/A  Work issues:  
Branch:  511b9ff (Commits, GitHub, GitLab)  Commit:  511b9ff92b50bb84b9673556ccc6aa879bfa9e93 
Dependencies:  Stopgaps: 
Description
Calculate the residue of a symbolic expression.
Change History (15)
comment:1 Changed 8 years ago by
 Branch set to u/dkrenn/ticket/15840
 Created changed from 02/20/14 19:02:07 to 02/20/14 19:02:07
 Modified changed from 02/20/14 19:02:07 to 02/20/14 19:02:07
comment:2 Changed 8 years ago by
 Commit set to e0d1169c703210ea7d0c4ce71a2df39b7ea15688
 Status changed from new to needs_review
comment:3 Changed 8 years ago by
comment:4 Changed 8 years ago by
 Status changed from needs_review to needs_work
comment:5 Changed 8 years ago by
Having some git troubles....solving them tomorrow... ;)
comment:6 Changed 8 years ago by
 Commit changed from e0d1169c703210ea7d0c4ce71a2df39b7ea15688 to ddca280e94f7f53180ceed35df5cda4e384fbb4b
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
ddca280  function 'residue' added

comment:7 Changed 8 years ago by
 Status changed from needs_work to needs_review
Now the correct things are pushed :)
comment:8 followups: ↓ 11 ↓ 12 ↓ 13 Changed 8 years ago by
 Branch changed from u/dkrenn/ticket/15840 to u/mmezzarobba/15840residue
 Commit changed from ddca280e94f7f53180ceed35df5cda4e384fbb4b to 9997eaaa8f35ccbc1034403ccc4b8434d30f2559
 Reviewers set to Marc Mezzarobba
Hi Daniel,
Thanks for your patch!
Your code didn't work on expressions such as 1/s² (with that particular variable name). I think I fixed it.
I am still not too happy about the following:
sage: var('s') sage: (x^s).residue(x,0) 0
but it's not clear to me what the code should do in such cases.
Also, I wonder if we shouldn't prefer a syntax such as expr.residue(x==a)
for consistency with series()
.
New commits:
9997eaa  Various improvements to expr.residue()

comment:9 Changed 8 years ago by
 Commit changed from 9997eaaa8f35ccbc1034403ccc4b8434d30f2559 to ae62ecaa973952ef96268e697d6525ba5512d307
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
ae62eca  Various improvements to expr.residue()

comment:10 Changed 8 years ago by
 Branch changed from u/mmezzarobba/15840residue to u/dkrenn/ticket/15840
 Modified changed from 02/22/14 18:18:40 to 02/22/14 18:18:40
comment:11 in reply to: ↑ 8 Changed 8 years ago by
 Commit changed from ae62ecaa973952ef96268e697d6525ba5512d307 to 511b9ff92b50bb84b9673556ccc6aa879bfa9e93
Replying to mmezzarobba:
Also, I wonder if we shouldn't prefer a syntax such as
expr.residue(x==a)
for consistency withseries()
.
Yes, good idea. I changed that.
New commits:
511b9ff  changed to support x==a syntax for consistency with .series()

comment:12 in reply to: ↑ 8 Changed 8 years ago by
Replying to mmezzarobba:
I am still not too happy about the following:
sage: var('s') sage: (x^s).residue(x,0) 0but it's not clear to me what the code should do in such cases.
It is also not clear to me, but this problem has to be solved in {.series()}}}. This is now #15854.
comment:13 in reply to: ↑ 8 Changed 8 years ago by
Replying to mmezzarobba:
Your code didn't work on expressions such as 1/s² (with that particular variable name). I think I fixed it.
Thanks. I reviewed your changes; looks good.
comment:14 Changed 8 years ago by
 Status changed from needs_review to positive_review
comment:15 Changed 8 years ago by
 Branch changed from u/dkrenn/ticket/15840 to 511b9ff92b50bb84b9673556ccc6aa879bfa9e93
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
First version of aau_howto
Workflow begonnen
function 'residue' added