Opened 7 years ago
Closed 6 years ago
#15814 closed defect (duplicate)
upgrade cunningham_table-1.0 and put it in standard
Reported by: | rws | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | packages: standard | Keywords: | cunningham, factorization |
Cc: | roed | Merged in: | |
Authors: | Ralf Stephan | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
The old package still uses $SAGE_DATA and so it fails to install after sage-6.0. Moreover, it should be upgraded as the newest version is http://sage.math.washington.edu/home/roed/cunningham_tables-2.2.spkg
That version however still uses $SAGE_DATA but the upgrader could just fix that by changing usage of it to $SAGE_SHARE.
Maintainer is cc'ed.
See #7240 why this should be standard, the vote has happened.
Change History (7)
comment:1 Changed 7 years ago by
- Component changed from packages: optional to packages: standard
- Description modified (diff)
- Summary changed from cunningham_table-1.0 fails to install, should be upgraded too to upgrade cunningham_table-1.0 and put it in standard
comment:2 Changed 7 years ago by
- Status changed from new to needs_review
The sage-spkg
script simply grabs any spkg-install
in the tarball without looking into build/pkgs/cunningham_tables
so, unless this has been enhanced, the only way to present this patched SPKG is by giving the patch above.
So, to include the new package, download the SPKG from the link above, extract the tarball, and patch the spkg-install
using the snippet above. The Sage tarball patch mechanism is not usable here, AFAIK, and neither is git.
comment:3 Changed 7 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:4 Changed 7 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:5 Changed 6 years ago by
- Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
Duplicate of #15813.
comment:6 Changed 6 years ago by
- Status changed from needs_review to positive_review
comment:7 Changed 6 years ago by
- Resolution set to duplicate
- Status changed from positive_review to closed
So, that's all to make the linked SPKG work:
Now to figure out what the actual patch should look like.