Opened 7 years ago

Closed 7 years ago

#15811 closed defect (fixed)

Random doctest failure in maxima_abstract.py

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.2
Component: interfaces Keywords:
Cc: Merged in:
Authors: Volker Braun Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: 580da04 (Commits) Commit: 580da046740eacb7ca82e4921638d053a94e751d
Dependencies: Stopgaps:

Description (last modified by vbraun)

This is yet again due to terminal echo showing up in unexpected places.

Change History (5)

comment:1 Changed 7 years ago by vbraun

  • Component changed from PLEASE CHANGE to interfaces
  • Description modified (diff)
  • Type changed from PLEASE CHANGE to defect

Example of failure:

sage -t --long src/sage/interfaces/maxima_abstract.py
**********************************************************************
File "src/sage/interfaces/maxima_abstract.py", line 2183, in sage.interfaces.maxima_abstract.MaximaAbstractElementFunction._add_
Failed example:
    f+3
Exception raised:
    Traceback (most recent call last):
      File "/home/buildbot/build/sage/snapperkob/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 480, in _run
        self.execute(example, compiled, test.globs)
      File "/home/buildbot/build/sage/snapperkob/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 839, in execute
        exec compiled in globs
      File "<doctest sage.interfaces.maxima_abstract.MaximaAbstractElementFunction._add_[4]>", line 1, in <module>
        f+Integer(3)
      File "element.pyx", line 1539, in sage.structure.element.RingElement.__add__ (sage/structure/element.c:13873)
      File "coerce.pyx", line 782, in sage.structure.coerce.CoercionModel_cache_maps.bin_op (sage/structure/coerce.c:7311)
      File "coerce.pyx", line 900, in sage.structure.coerce.CoercionModel_cache_maps.canonical_coercion (sage/structure/coerce.c:8549)
      File "morphism.pyx", line 287, in sage.categories.morphism.CallMorphism._call_ (sage/categories/morphism.c:4698)
      File "/home/buildbot/build/sage/snapperkob/sage_git/build/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 201, in __call__
        return self._coerce_from_special_method(x)
      File "/home/buildbot/build/sage/snapperkob/sage_git/build/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 227, in _coerce_from_special_method
        return (x.__getattribute__(s))(self)
      File "sage_object.pyx", line 603, in sage.structure.sage_object.SageObject._maxima_ (sage/structure/sage_object.c:6329)
      File "sage_object.pyx", line 515, in sage.structure.sage_object.SageObject._interface_ (sage/structure/sage_object.c:4373)
      File "/home/buildbot/build/sage/snapperkob/sage_git/build/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 199, in __call__
        return cls(self, x, name=name)
      File "/home/buildbot/build/sage/snapperkob/sage_git/build/local/lib/python2.7/site-packages/sage/interfaces/maxima.py", line 1127, in __init__
        ExpectElement.__init__(self, parent, value, is_name=False, name=None)
      File "/home/buildbot/build/sage/snapperkob/sage_git/build/local/lib/python2.7/site-packages/sage/interfaces/expect.py", line 1291, in __init__
        self._name = parent._create(value, name=name)
      File "/home/buildbot/build/sage/snapperkob/sage_git/build/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 389, in _create
        self.set(name, value)
      File "/home/buildbot/build/sage/snapperkob/sage_git/build/local/lib/python2.7/site-packages/sage/interfaces/maxima.py", line 972, in set
        self._eval_line(cmd)
      File "/home/buildbot/build/sage/snapperkob/sage_git/build/local/lib/python2.7/site-packages/sage/interfaces/maxima.py", line 759, in _eval_line
        assert line_echo.strip() == line.strip(), 'mismatch:\n' + line_echo + line
    AssertionError: mismatch:
    kill(sage144)$sage225 : 3$

    sage225 : 3$
**********************************************************************

comment:2 Changed 7 years ago by vbraun

  • Branch set to u/vbraun/random_doctest_failure_in_maxima_abstract_py

comment:3 Changed 7 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to 580da046740eacb7ca82e4921638d053a94e751d
  • Status changed from new to needs_review

New commits:

580da04ignore randomness in assertion

comment:4 Changed 7 years ago by jpflori

  • Reviewers set to Jean-Pierre Flori
  • Status changed from needs_review to positive_review

Looks simple enough and should do the trick.

comment:5 Changed 7 years ago by vbraun

  • Branch changed from u/vbraun/random_doctest_failure_in_maxima_abstract_py to 580da046740eacb7ca82e4921638d053a94e751d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.