Opened 8 years ago
Last modified 5 years ago
#15809 needs_work enhancement
Compile Denis Simon's scripts with gp2c
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sagewishlist 
Component:  interfaces  Keywords:  
Cc:  embray  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/jdemeyer/ticket/15809 (Commits, GitHub, GitLab)  Commit:  86ef8147702939e0deb427a98c5de296a5b4074b 
Dependencies:  #18874, #19860  Stopgaps: 
Description (last modified by )
After merging Simon's scripts into one script, they are turned into C code by gp2c
, which is then compiled into the Sage <> PARI library interface.
Using them is exactly the same as using other PARI functions:
sage: EllipticCurve("389a1")._pari_().ellrank() [2, 2, [[1/16, 9/64], [5/4, 5/8]]]
The focus of this ticket is really on making a general mechanism, not so much on Simon's scripts (in particular, simon_two_descent
has not been changed). It should be very easy to add new scripts in the future.
Change History (14)
comment:1 Changed 8 years ago by
 Component changed from PLEASE CHANGE to interfaces
 Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:4 Changed 7 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:5 Changed 7 years ago by
 Dependencies changed from #11005 to #258
comment:6 Changed 7 years ago by
 Dependencies changed from #258 to #258, #18874
comment:7 Changed 7 years ago by
 Dependencies changed from #258, #18874 to #258, #18874, #18583
comment:8 Changed 7 years ago by
 Branch set to u/jdemeyer/ticket/15809
comment:9 Changed 7 years ago by
 Commit set to 9322e17de2e26c31121e31890b56637c51a62aa9
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
a6e0513  Remove duplicate global variables

e7cdb76  Add a gp2c optional package

fbd976e  Add fixes for PARI 2.8

2daa9ae  Add a patch to fix global()

ad14931  Merge commit '2daa9ae692d1f1fc2d1799aec0b57cae76022e41'; commit 'd9c97acc74bebfb486d55a9e35263851f42e6845' into t/18874/fix_braces_in_simon_scripts

9322e17  Compile Denis Simon's scripts with gp2c

comment:10 Changed 7 years ago by
 Description modified (diff)
 Milestone changed from sage6.4 to sage6.8
 Status changed from new to needs_review
comment:11 Changed 6 years ago by
 Commit changed from 9322e17de2e26c31121e31890b56637c51a62aa9 to c00347845a67fa0e6996dad577f3707f198876a2
comment:12 Changed 6 years ago by
 Dependencies changed from #258, #18874, #18583 to #18874, #19860
comment:13 Changed 6 years ago by
 Commit changed from c00347845a67fa0e6996dad577f3707f198876a2 to 86ef8147702939e0deb427a98c5de296a5b4074b
Branch pushed to git repo; I updated commit sha1. New commits:
86ef814  Minor changes

comment:14 Changed 5 years ago by
 Cc embray added
 Milestone changed from sage6.8 to sagewishlist
 Status changed from needs_review to needs_work
Obviously needs to be reworked insofar as how the build steps fit in, but looks like a good idea otherwise. It would also be good to incorporate Tim Dokchitser's script src/ext/pari/dokchitser/computel.gp
. This would probably enable rewriting sage.lfunctions.dokchitser
to use the pari interface instead of gp+pexpect; see #22718.
I might take a stab at this if Jeroen doesn't get a chance first.
Are we sure that this would yield a significant speedup? I have not profiled this at all, but if most of the time is spent in PARI functions like
bnfinit()
, then gp2c will not help.