Opened 2 years ago
Closed 2 years ago
#15805 closed defect (fixed)
the qinteger 0 has no parent.
Reported by:  chapoton  Owned by:  

Priority:  minor  Milestone:  sage6.2 
Component:  combinatorics  Keywords:  qanalogs 
Cc:  sagecombinat  Merged in:  
Authors:  Travis Scrimshaw  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  80450c0 (Commits)  Commit:  80450c0b9ab464dc06c38568f91f70be744f13df 
Dependencies:  Stopgaps: 
Description
For uniformity, all qintegers should belong to the polynomial ring in q over ZZ.
sage: from sage.combinat.q_analogues import q_int sage: q_int(1).parent() Univariate Polynomial Ring in q over Integer Ring sage: q_int(0).parent()  AttributeError Traceback (most recent call last) <ipythoninput3f312dad40f56> in <module>() > 1 q_int(Integer(0)).parent() AttributeError: 'int' object has no attribute 'parent'
Change History (5)
comment:1 Changed 2 years ago by
 Branch set to public/combinat/q_int_parent15805
 Cc sagecombinat added
 Commit set to d1ea9d8bfbba01fbeef4f4ae50a19127bfeea2a2
 Status changed from new to needs_review
comment:2 Changed 2 years ago by
 Commit changed from d1ea9d8bfbba01fbeef4f4ae50a19127bfeea2a2 to 80450c0b9ab464dc06c38568f91f70be744f13df
Branch pushed to git repo; I updated commit sha1. New commits:
80450c0  trac #15805 : small enhancement

comment:3 Changed 2 years ago by
Thanks, Travis.
This looks good to me. If you approve my small change, you can set a positive review
comment:4 Changed 2 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
Then positive review. Thanks Frederic.
comment:5 Changed 2 years ago by
 Branch changed from public/combinat/q_int_parent15805 to 80450c0b9ab464dc06c38568f91f70be744f13df
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
We should be consistent about this.
New commits:
Added special case of q_int(0).