Opened 7 years ago
Closed 7 years ago
#15768 closed enhancement (fixed)
Cleanup logic documentation
Reported by:  tscrim  Owned by:  tscrim 

Priority:  minor  Milestone:  sage6.3 
Component:  documentation  Keywords:  
Cc:  Merged in:  
Authors:  Travis Scrimshaw  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  d663737 (Commits)  Commit:  d66373780133c4cef7fa6a91250b2262e1ca4e9a 
Dependencies:  #15018  Stopgaps: 
Description
Because a bunch of files aren't there.
Change History (14)
comment:1 Changed 7 years ago by
 Branch set to public/documentation/logic15768
 Commit set to a7ab40ac20169298071b55e4d587740164afa2f5
 Priority changed from major to minor
 Status changed from new to needs_review
comment:2 Changed 7 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:3 Changed 7 years ago by
 Status changed from needs_review to needs_work
 Work issues set to needs rebase
comment:4 Changed 7 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:5 Changed 7 years ago by
 Commit changed from a7ab40ac20169298071b55e4d587740164afa2f5 to 7f012c5da79b922f8f80097ea88eb169972a108c
comment:6 Changed 7 years ago by
 Status changed from needs_work to needs_review
 Work issues needs rebase deleted
comment:7 Changed 7 years ago by
 Commit changed from 7f012c5da79b922f8f80097ea88eb169972a108c to 87b38093164515bbad80018d38cf1b8223f8837b
Branch pushed to git repo; I updated commit sha1. New commits:
87b3809  Merge branch 'public/documentation/logic15768' of trac.sagemath.org:sage into public/documentation/logic15768

comment:8 Changed 7 years ago by
 Commit changed from 87b38093164515bbad80018d38cf1b8223f8837b to 069662d0452d0a6fdca5b8ca4ca1f2cf18bd227d
Branch pushed to git repo; I updated commit sha1. New commits:
069662d  trac #15768 review patch

comment:9 Changed 7 years ago by
ok, looks good to me. Travis, can you please have a look at my small changes and set a positive review on my behalf if you agree with them ?
comment:10 Changed 7 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
LGTM, thanks Frederic.
comment:11 Changed 7 years ago by
 Status changed from positive_review to needs_work
Conflicts, please merge in next beta
comment:12 Changed 7 years ago by
 Commit changed from 069662d0452d0a6fdca5b8ca4ca1f2cf18bd227d to d66373780133c4cef7fa6a91250b2262e1ca4e9a
Branch pushed to git repo; I updated commit sha1. New commits:
d663737  Merge branch 'public/documentation/logic15768' of ssh://trac.sagemath.org:22/sage into 15768

comment:13 Changed 7 years ago by
 Status changed from needs_work to positive_review
comment:14 Changed 7 years ago by
 Branch changed from public/documentation/logic15768 to d66373780133c4cef7fa6a91250b2262e1ca4e9a
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I also gave it to 100% doctest coverage.
New commits:
Trac 15018: added recover_formula, recover_formula_internal, prefix_to_infix, and to_infix_internal to logicparser.py
Minor review tweaks.
Merge branch 'develop' into public/ticket/15018
Merge branch 'develop' into public/ticket/15018
Cleaned up documentation in logicparser.py.
Full doctest coverage and cleaned up doc in logic folder.