Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#15732 closed defect (fixed)

OS X app fails with no warning when run on read only file system (e.g. dmg)

Reported by: iandrus Owned by:
Priority: major Milestone: sage-6.3
Component: user interface Keywords: mac app
Cc: Merged in:
Authors: Ivan Andrus Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: eb13458 (Commits) Commit:
Dependencies: Stopgaps:

Description

When run directly from the disk image the OS X application should at least warn that it won't work instead of silently refusing to start.

Change History (11)

comment:1 Changed 7 years ago by kcrisman

I have run into this on numerous occasions but had gotten a semi-useful message. But you are right that this should be really clear, maybe suggesting also to "drag to Applications" or "read the README" or something. Not everyone knows what a README is, after all.

comment:2 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:3 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:4 Changed 7 years ago by iandrus

  • Authors set to Ivan Andrus
  • Branch set to u/iandrus/mac-app-readwrite
  • Commit set to eb134581fc1b354948e99e150e6c5fdd63cd9120

Here are some changes to show a (modal) dialog in the case that it's being run from a read-only file system e.g. disk image.

I also included some fixes to warnings. So that's what those other changes are.

comment:5 Changed 7 years ago by iandrus

  • Status changed from new to needs_review

comment:6 follow-up: Changed 7 years ago by kcrisman

Two questions:

  • What is project.xcworkspace/xcshareddata/Sage.xccheckout? It doesn't seem to fit in either of the categories you mention, though it looks like a harmless informational file.
  • What versions of OS X have you tested this on so far? Does it rely on a newer Xcode? (Just asking.)

comment:7 in reply to: ↑ 6 Changed 7 years ago by iandrus

Replying to kcrisman:

Two questions:

  • What is project.xcworkspace/xcshareddata/Sage.xccheckout? It doesn't seem to fit in either of the categories you mention, though it looks like a harmless informational file.

It's a file the new Xcode uses to keep track of repositories. Since we now use git and Xcode understands git, it got created. Apparently it should be checked in to version control, so I did: http://stackoverflow.com/questions/18340453/should-xccheckout-files-in-xcode5-be-ignored-under-vcs

But yes, it should be harmless.

  • What versions of OS X have you tested this on so far? Does it rely on a newer Xcode? (Just asking.)

I have only tested it on Mavericks, though I intentionally did not upgrade the Xcode project so it should work with any version of Xcode that it did before.

comment:8 Changed 7 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:9 Changed 7 years ago by kcrisman

Thanks, Volker, I'm woefully behind on reviewing. One would think I have a real job not involving Sage or something... Still haven't tested it on 10.4 but I guess it isn't supported anyway ;-)

comment:10 Changed 7 years ago by vbraun

  • Branch changed from u/iandrus/mac-app-readwrite to eb134581fc1b354948e99e150e6c5fdd63cd9120
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:11 Changed 6 years ago by kcrisman

  • Commit eb134581fc1b354948e99e150e6c5fdd63cd9120 deleted

The NSModalResponse causes problems on everything except 10.9. See #16796.

Note: See TracTickets for help on using tickets.