Opened 9 years ago

Closed 9 years ago

#15717 closed defect (fixed)

Add some sig_on() in Singular library

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-6.2
Component: interfaces Keywords:
Cc: Punarbasu Purkayastha Merged in:
Authors: Jeroen Demeyer Reviewers: Punarbasu Purkayastha
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/ticket/15717 (Commits, GitHub, GitLab) Commit: 13573a935764c03692d67661fbc31fa3cedf1349
Dependencies: #14333 Stopgaps:

Status badges

Description

This hangs (see #15710) and cannot be interrupted:

sage: F.<a>=CyclotomicField(49); G = F['z,w'].fraction_field(); 1/G(a^28 + a^23 - 1)

The attached branch fixes the "cannot be interrupted" part of the bug.

Change History (8)

comment:1 Changed 9 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/15717
Created: Jan 23, 2014, 4:02:58 PMJan 23, 2014, 4:02:58 PM
Modified: Jan 23, 2014, 4:02:58 PMJan 23, 2014, 4:02:58 PM

comment:2 Changed 9 years ago by Jeroen Demeyer

Commit: 13573a935764c03692d67661fbc31fa3cedf1349
Status: newneeds_review

New commits:

1753f06Update Singular to version 3-1-6.
536a31fUpdate Singular function interface to API changes in Singular 3.1.6.
dd46991Remove description of deleted patches.
0a702e9Merge commit 'dd469911d19ed7080fec' into ticket/15710
13573a9Add some sig_on() blocks to Singular interface

comment:3 Changed 9 years ago by Jeroen Demeyer

Dependencies: #14333

comment:4 Changed 9 years ago by Punarbasu Purkayastha

Thanks, I just tested it and this works. But, we don't need #14333. I just cherry-picked the last commit on to develop and the interrupt worked very well. :)

comment:5 Changed 9 years ago by Jeroen Demeyer

Sure, but I started #15710 by checking whether #14333 would fix it and any fix for #15710 would probably need to be based on #14333. And I just copied that commit here. Given that #14333 has positive review, it's not a problem, right?

comment:6 Changed 9 years ago by Punarbasu Purkayastha

Reviewers: Punarbasu Purkayastha
Status: needs_reviewpositive_review

Yeah. I guess it shouldn't matter.

comment:7 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:8 Changed 9 years ago by Volker Braun

Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.