Opened 8 years ago

Closed 8 years ago

#15699 closed defect (fixed)

Glibc scanf workaround for ATLAS

Reported by: vbraun Owned by:
Priority: blocker Milestone: sage-6.1
Component: build Keywords:
Cc: jdemeyer, jpflori, emassop Merged in:
Authors: Volker Braun, Erik Massop Reviewers: Jean-Pierre Flori, Jeroen Demeyer
Report Upstream: Fixed upstream, in a later stable release. Work issues: SPKG.txt
Branch: u/vbraun/glibc_scanf_workaround_for_atlas (Commits, GitHub, GitLab) Commit: 6705395d4d49c83be63ff19c7afd94d426e551a1
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

Workaround for the glibc-2.18 bug that breaks the ATLAS build system

​https://sourceware.org/bugzilla/show_bug.cgi?id=15917

Change History (11)

comment:1 Changed 8 years ago by vbraun

  • Branch set to u/vbraun/glibc_scanf_workaround_for_atlas

comment:2 Changed 8 years ago by vbraun

  • Authors set to Volker Braun
  • Branch u/vbraun/glibc_scanf_workaround_for_atlas deleted
  • Component changed from PLEASE CHANGE to build
  • Description modified (diff)
  • Report Upstream changed from N/A to Fixed upstream, in a later stable release.
  • Type changed from PLEASE CHANGE to defect

comment:3 Changed 8 years ago by vbraun

  • Branch set to u/vbraun/glibc_scanf_workaround_for_atlas
  • Commit set to 540db9e21198d9fb082be954e51ab8903501e574

New commits:

​540db9eWorkaround for glibc-2.18 scanf bug when building ATLAS

comment:4 Changed 8 years ago by vbraun

  • Cc jdemeyer jpflori added
  • Priority changed from major to blocker
  • Status changed from new to needs_review

comment:5 follow-up: Changed 8 years ago by jpflori

Shouldn't you bump the version number in package-version.txt to trigger a rebuild? (Ok, on system where this is actually needed, ATLAS could not build before...)

comment:6 Changed 8 years ago by jpflori

And document the patch in SPKG.txt...

comment:7 in reply to: ↑ 5 Changed 8 years ago by jdemeyer

Replying to jpflori:

Shouldn't you bump the version number in package-version.txt to trigger a rebuild? (Ok, on system where this is actually needed, ATLAS could not build before...)

There is no need to rebuild ATLAS on every system after this patch, so I see no reason to bump the patchlevel.

comment:8 Changed 8 years ago by jdemeyer

  • Status changed from needs_review to needs_work
  • Work issues set to SPKG.txt

comment:9 Changed 8 years ago by git

  • Commit changed from 540db9e21198d9fb082be954e51ab8903501e574 to 6705395d4d49c83be63ff19c7afd94d426e551a1

Branch pushed to git repo; I updated commit sha1. New commits:

​036a5cdAvoid scanf instead of just ignoring rest of file
​6705395document the glibc bug workaround patch

comment:10 Changed 8 years ago by vbraun

  • Authors changed from Volker Braun to Volker Braun, Erik Massop
  • Cc emassop added
  • Reviewers set to Jean-Pierre Flori, Jeroen Demeyer
  • Status changed from needs_work to positive_review

Fixed

comment:11 Changed 8 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.