Opened 8 years ago

Closed 8 years ago

#15694 closed task (fixed)

Remove deprecation warning for elliptic curve isogeny class method

Reported by: cremona Owned by: cremona
Priority: minor Milestone: sage-6.2
Component: elliptic curves Keywords: isogeny class
Cc: roed Merged in:
Authors: John Cremona Reviewers: Chris Wuthrich
Report Upstream: N/A Work issues:
Branch: u/cremona/ticket/15694 Commit: 3241d4716aace090096792682b89677d59bfb333
Dependencies: Stopgaps:

Status badges

Description

In #12768 a deprecation warning was introduced for the elliptic curve (over QQ) isogeny_class function together with the parameter use_tuple which defaults to True (old-style output), though using this value shows a deprecation warning.

We should switch the default to use_tuple=False and adjust the doctests accordingly.

I see no particular reason to remove the old-style (and current default) behaviour altogether, but in any case that would be for another ticket.

Change History (5)

comment:1 Changed 8 years ago by cremona

  • Owner changed from (none) to cremona

comment:2 Changed 8 years ago by cremona

  • Branch set to u/cremona/ticket/15694
  • Commit set to 3241d4716aace090096792682b89677d59bfb333
  • Status changed from new to needs_review

New commits:

3241d47Trac #15694: remove deprecation warning for elliptic curve isogeny class method

comment:3 Changed 8 years ago by wuthrich

  • Authors set to John Cremona
  • Reviewers set to Chris Wuthrich
  • Status changed from needs_review to positive_review

Brilliant. Thank you very much for doing this. I found the warning for a default value a very annoying thing.

All tests pass. The branch merges without problem into 6.1.rc0.

comment:4 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:5 Changed 8 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.