Opened 5 years ago

Closed 5 years ago

#15679 closed defect (fixed)

Fixes for Singular on Cygwin64.

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.2
Component: porting: Cygwin Keywords: singular cygwin spkg
Cc: kcrisman, dimpase, tscrim, vbraun Merged in:
Authors: Jean-Pierre Flori Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 3a72203 (Commits) Commit: 3a7220348f2b5befd5f382fc5a818b9275f78f41
Dependencies: #14333 Stopgaps:

Description (last modified by jpflori)

It seems ld on Cygwin64 does not look for .so extension and so fails to find libsingular.so. Indeed Singular is ill configured on Cygwin64.

This also disables omGetBacktrace on Cygwin64 as it seems to be broken.

The fixes here are jsut temporary as Singular4 build system is quite different anyway.

Change History (15)

comment:1 Changed 5 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to u/jpflori/ticket/15679
  • Dependencies set to #14333
  • Description modified (diff)
  • Keywords singulat cygwin spkg added
  • Summary changed from ld cannot find libsingular on Cygwin64. to Fixes for Singular on Cygwin64.

comment:2 Changed 5 years ago by git

  • Commit set to ce905651bef34b035148f828482778d7fe0f00b6

Branch pushed to git repo; I updated commit sha1. New commits:

1753f06Update Singular to version 3-1-6.
536a31fUpdate Singular function interface to API changes in Singular 3.1.6.
dd46991Remove description of deleted patches.
358356bMerge remote-tracking branch 'trac/u/jpflori/ticket/14333' into ticket/15679
ce90565Fix Singular build on Cygwin64.

comment:3 Changed 5 years ago by jpflori

  • Keywords singular added; singulat removed
  • Status changed from new to needs_review

comment:4 Changed 5 years ago by git

  • Commit changed from ce905651bef34b035148f828482778d7fe0f00b6 to b19dde1ec37019189d4e986f7de1260846f0b429

Branch pushed to git repo; I updated commit sha1. New commits:

b19dde1Moved patch for Singular went untracked.

comment:5 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 5 years ago by fwclarke

  • Status changed from needs_review to needs_work

The changes to src/sage/libs/singular/function.pyx mean that I can't rebuild sage with OS X 9.1. The key error messages are

sage/libs/singular/function.cpp:11286:90: error: invalid conversion from 'sleftv*' to 'int' [-fpermissive]
sage/libs/singular/function.cpp:11323:38: error: no matching function for call to 'sleftv::Copy(sleftv**)'

comment:7 follow-up: Changed 5 years ago by jpflori

  • Status changed from needs_work to needs_info

I don't think this ticket modified that file, did it?

comment:8 in reply to: ↑ 7 Changed 5 years ago by fwclarke

Replying to jpflori:

I don't think this ticket modified that file, did it?

http://git.sagemath.org/sage.git/commit/?id=536a31f920117a8d048447f6b7a7477bcffc213a says so.

comment:9 follow-up: Changed 5 years ago by jpflori

That's #14333.

comment:10 in reply to: ↑ 9 Changed 5 years ago by fwclarke

Replying to jpflori:

That's #14333.

Ah. I didn't understand that a commit could be listed under two tickets. Having found the commit, I think I just searched for tickets in which you were an author and the summary contained singular.

I see now that the problem I had has been picked up in sage-release. Sorry for bothering you.

comment:11 Changed 5 years ago by git

  • Commit changed from b19dde1ec37019189d4e986f7de1260846f0b429 to 3a7220348f2b5befd5f382fc5a818b9275f78f41

Branch pushed to git repo; I updated commit sha1. New commits:

3a72203Merge remote-tracking branch 'trac/develop' into ticket/15679

comment:12 Changed 5 years ago by jpflori

  • Status changed from needs_info to needs_review

comment:13 Changed 5 years ago by jpflori

  • Cc vbraun added

This one is also Cygwin64 specific.

comment:14 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:15 Changed 5 years ago by vbraun

  • Branch changed from u/jpflori/ticket/15679 to 3a7220348f2b5befd5f382fc5a818b9275f78f41
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.