Opened 8 years ago

Closed 8 years ago

#15675 closed defect (fixed)

Sanitize source tarball permissions

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.1
Component: distribution Keywords:
Cc: Merged in:
Authors: Volker Braun Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: u/vbraun/ticket/15675 (Commits, GitHub, GitLab) Commit: ad34efd5006cbf9342f1033cf1693ba2feef413d
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Files in sdist/bdist tarballs should have permissions either 0644 or 0755, nothing else.

Change History (16)

comment:1 Changed 8 years ago by vbraun

  • Component changed from PLEASE CHANGE to distribution
  • Description modified (diff)
  • Status changed from new to needs_info
  • Type changed from PLEASE CHANGE to defect

comment:3 Changed 8 years ago by jdemeyer

  • Description modified (diff)
  • Priority changed from major to blocker

comment:4 Changed 8 years ago by vbraun

  • Branch set to u/vbraun/sanitize_source_tarball_permissions

comment:5 Changed 8 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to a90c1900b904a77a4e660f9f9bab1b55086fc87b
  • Priority changed from blocker to major
  • Status changed from needs_info to needs_review

New commits:

a90c190sanitize write permissions before creating tarballs

comment:6 Changed 8 years ago by jdemeyer

Merged and changed go-w to go=rX.

comment:7 Changed 8 years ago by jdemeyer

  • Branch changed from u/vbraun/sanitize_source_tarball_permissions to u/jdemeyer/ticket/15675
  • Created changed from 01/15/14 06:00:42 to 01/15/14 06:00:42
  • Modified changed from 01/16/14 10:06:34 to 01/16/14 10:06:34

comment:8 Changed 8 years ago by vbraun

  • Commit changed from a90c1900b904a77a4e660f9f9bab1b55086fc87b to f4fc8414200fa1de56003005c8869fb0f2b2170e
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

New commits:

5e87e4eMerge remote-tracking branch 'origin/develop' into ticket/15675
f4fc841Set tarball permissions to go=rX

comment:9 Changed 8 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 8 years ago by vbraun

Fails on OSX 10.9:

Sage build/upgrade complete!
Creating dist/sage-6.1.beta5.tar.gz ...
chmod: illegal option -- -
usage:	chmod [-fhv] [-R [-H | -L | -P]] [-a | +a | =a  [i][# [ n]]] mode|entry file ...
	chmod [-fhv] [-R [-H | -L | -P]] [-E | -C | -N | -i | -I] file ...

comment:11 Changed 8 years ago by vbraun

  • Resolution fixed deleted
  • Status changed from closed to new

comment:12 Changed 8 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/15675 to u/vbraun/ticket/15675

comment:13 Changed 8 years ago by git

  • Commit changed from f4fc8414200fa1de56003005c8869fb0f2b2170e to ad34efd5006cbf9342f1033cf1693ba2feef413d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ad34efdDo not use the GNU extension chmod --recursive

comment:14 Changed 8 years ago by vbraun

  • Status changed from new to needs_review

comment:15 Changed 8 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:16 Changed 8 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.