Opened 6 years ago

Closed 6 years ago

#15668 closed enhancement (fixed)

implement the fixed complex of automorphisms of simplicial complexes

Reported by: chapoton Owned by:
Priority: major Milestone: sage-6.2
Component: algebraic topology Keywords: simplicial complex
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 74a606d (Commits) Commit: 74a606dbcbcf19fb1e2087eca432c5e2eca04ec7
Dependencies: Stopgaps:

Description

This is a useful tool to have, I think.

Change History (13)

comment:1 Changed 6 years ago by chapoton

  • Branch set to u/chapoton/15668
  • Commit set to 1d99ff8761997639c856de5b61807b79f0ec3d4d
  • Status changed from new to needs_review

New commits:

1d99ff8trac #15668 implement fixed simplicial complex

comment:2 Changed 6 years ago by chapoton

  • Authors set to Frédéric Chapoton

comment:3 Changed 6 years ago by git

  • Commit changed from 1d99ff8761997639c856de5b61807b79f0ec3d4d to f296f4f61f17e6a090c4e78a17721e524f046817

Branch pushed to git repo; I updated commit sha1. New commits:

f296f4ftrac #15668 more general input is allowed

comment:4 Changed 6 years ago by git

  • Commit changed from f296f4f61f17e6a090c4e78a17721e524f046817 to d7a75bffc043f1531d409bf706f0072043cdce80

Branch pushed to git repo; I updated commit sha1. New commits:

d7a75bftrac #15668 added a basic example + correct raise syntax for python3

comment:5 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 6 years ago by chapoton

  • Status changed from needs_review to needs_work

This is not correct so far, needs works.

comment:7 Changed 6 years ago by git

  • Commit changed from d7a75bffc043f1531d409bf706f0072043cdce80 to 4af4e2c15e023bf58aadf563d55f0ac39d48daea

Branch pushed to git repo; I updated commit sha1. New commits:

13cbb1ctrac #15668 implement fixed simplicial complex
d8fe179trac #15668 more general input is allowed
1860ed3trac #15668 added a basic example + correct raise syntax for python3
222dd04trac #15668 correct algo ?
4af4e2ctrac #15668 more doc

comment:8 Changed 6 years ago by chapoton

  • Status changed from needs_work to needs_review

Better now. Needs review

comment:9 Changed 6 years ago by tscrim

  • Branch changed from u/chapoton/15668 to u/tscrim/fixed_complex_15668
  • Commit 4af4e2c15e023bf58aadf563d55f0ac39d48daea deleted
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Hey Frederic,

I just made two minor tweaks: one is fixed the alignment of the INPUT: bullet point and the other is to use the .format instead of % for string formatting. I'm setting this to positive review since my tweaks are so minor and everything else LGTM. Thanks.

comment:10 Changed 6 years ago by git

  • Commit set to 74a606dbcbcf19fb1e2087eca432c5e2eca04ec7
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

13cbb1ctrac #15668 implement fixed simplicial complex
d8fe179trac #15668 more general input is allowed
1860ed3trac #15668 added a basic example + correct raise syntax for python3
222dd04trac #15668 correct algo ?
4af4e2ctrac #15668 more doc
74a606dMinor formatting review changes.

comment:11 Changed 6 years ago by tscrim

  • Branch changed from u/tscrim/fixed_complex_15668 to u/tscrim/fixed_complex-15668
  • Status changed from needs_review to positive_review

comment:12 Changed 6 years ago by chapoton

Thanks a lot !

comment:13 Changed 6 years ago by vbraun

  • Branch changed from u/tscrim/fixed_complex-15668 to 74a606dbcbcf19fb1e2087eca432c5e2eca04ec7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.