Changes between Initial Version and Version 4 of Ticket #15664


Ignore:
Timestamp:
01/11/14 16:59:44 (7 years ago)
Author:
ncohen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15664

    • Property Cc chapoton Stefan wdj added
    • Property Status changed from new to needs_work
    • Property Branch changed from to u/ncohen/15664
  • Ticket #15664 – Description

    initial v4  
    1212Before:
    1313{{{
    14 sage: D = IncidenceStructure(range(32),designs.steiner_quadruple_system(32))
     14sage: D = IncidenceStructure(range(44),designs.steiner_quadruple_system(44))
    1515sage: time D.is_block_design()                                             
    16 CPU times: user 14.31 s, sys: 0.00 s, total: 14.32 s
    17 Wall time: 14.33 s
    18 (True, [3, 32, 4, 1])
     16CPU times: user 99.26 s, sys: 0.06 s, total: 99.32 s
     17Wall time: 99.40 s
     18(True, [3, 44, 4, 1])
    1919}}}
    2020
    2121After:
    2222{{{
    23 sage: D = IncidenceStructure(range(32),designs.steiner_quadruple_system(32))
     23sage: D = IncidenceStructure(range(44),designs.steiner_quadruple_system(44))
    2424sage: time D.is_block_design()                                             
    25 CPU times: user 0.18 s, sys: 0.01 s, total: 0.19 s
    26 Wall time: 0.17 s
    27 (True, [2, 32, 4, 15])
     25CPU times: user 0.06 s, sys: 0.00 s, total: 0.06 s
     26Wall time: 0.06 s
     27(True, [3, 44, 4, 1])
    2828}}}
     29
     30Secondly, `IncidenceStructure.parameter` has a very tricky behaviour :
     31{{{
     32sage: D = IncidenceStructure(range(44),designs.steiner_quadruple_system(44))
     33sage: D.is_block_design()                                                   
     34(True, [3, 44, 4, 1])
     35sage: D.parameters()                                                       
     36(2, 44, 4, 21)
     37}}}
     38
     39This is because `parameters()` take `t` as a parameter, and sets it to `2` by default. That's.... surprising `:-P`
     40
     41This patch adds a deprecation warning when this parameter is not set, and we will make it mandatory... in a while.
     42
     43Here it is !
     44
     45Nathann